fix

Change-Id: I60da50be34cdf38e61ad4f97019a90c261a97725

Author: evil-shrike

.gitignore

@@ -1 +1,2 @@
-.DS_Store
+.DS_Store
+replacements.txt

README.md

@@ -172,7 +172,12 @@ The application does not use any database. Instead all data is kept in Google Sp
 There are two type of environment in GAE: standard and flexible. See https://cloud.google.com/appengine/docs/the-appengine-environments
 As flexibile environment doesn't provide Free Tier we use standard. But you can manually change the environemnt in your `app.yaml`. Standard environment allows to scale down to 0 running instances when the application is not in use.
 
-There are several types of scaling in standard environment. By default automatic scaling is used. Different scaling type have [different characterictics](https://cloud.google.com/appengine/docs/standard/nodejs/how-instances-are-managed#scaling_types). For this solution the most important one is *request timeout*. During main execution there will lots of calls to DV360 API (to enable/disable IO/LI) and the API is quite slow. So one execution can last quite long.
+There are several types of scaling in standard environment. By default automatic scaling is used. 
+Different scaling type have [different characterictics](https://cloud.google.com/appengine/docs/standard/nodejs/how-instances-are-managed#scaling_types). 
+For this solution the most important one is *request timeout*. 
+During main execution there will lots of calls to DV360 API (to enable/disable IO/LI) and the API is quite slow. 
+So one execution can last quite long.
+
 Request timeouts are following:
 * Automatic scaling : 10 minutes
 * Basic/manual scaling: 24 hours

backend/.env.example

@@ -0,0 +1 @@
+OPENWEATHER_API_KEY=your_api_key_here

backend/.gitignore

@@ -10,4 +10,4 @@ src/test/credentials.json
 .DS_Store
 app.yaml
 app.yaml.original
-mailer.json
+mailer.json.env

backend/package.json

@@ -35,6 +35,7 @@
     "@js-joda/core": "^4.0.0",
     "csv": "^5.5.3",
     "csv-parse": "^4.16.3",
+    "dotenv": "^17.2.3",
     "express": "^4.17.1",
     "gaxios": "^4.3.2",
     "google-auth-library": "^9.8.0",

backend/src/app/dv360-facade.ts

@@ -221,7 +221,7 @@ export default class DV360Facade {
             "filterType": "FILTER_TYPE_CAMPAIGN_ID",
             "filterIds": [campaignId]
           },
-          //version: "SDF_VERSION_5_3" //SDF_VERSION_UNSPECIFIED
+          //version: "SDF_VERSION_7" - NOTE: we're not hard-coding and configure SDF version, instead we rely on what is set in Advertiser's settings
         },
       })).data;
     } catch(e) {

backend/src/index.ts

@@ -13,6 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import * as dotenv from "dotenv";
+dotenv.config();
+
 import { PORT, IS_GAE } from './env';
 import argv from './argv';
 import { google } from 'googleapis';