From 1ef9e2c543138e3c5906b56578bb4aa30dbfde0d Mon Sep 17 00:00:00 2001 From: Tzafrir Cohen Date: Sat, 24 Feb 2018 15:54:24 +0200 Subject: [PATCH] mkstemp: already returns an open file descriptor * No need to re-open the file returned by mkstemp. * If you don't close it, you leak a file descriptor and end up with too many open files. --- knesset_data/protocols/base.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/knesset_data/protocols/base.py b/knesset_data/protocols/base.py index 21f1744..67d87b8 100644 --- a/knesset_data/protocols/base.py +++ b/knesset_data/protocols/base.py @@ -64,8 +64,7 @@ def file_name(self): return self._file_data else: suffix = ".%s"%self.file_extension if self.file_extension is not None else "" - fid, fname = mkstemp(suffix=suffix, prefix=self.temp_file_suffix) - f = open(fname, 'wb') + with f, fname = mkstemp(suffix=suffix, prefix=self.temp_file_suffix) f.write(self.file_contents) f.close() self._cleanup.append(lambda: os.remove(fname))