Don't modify SSLContext::DEFAULT_PARAMS #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenSSL::SSL::SSLContext#set_params has had secure defaults since ruby 2.4 or 2.5. Since support for ruby versions prior to 3.1 has been dropped, there's no need to modify this anymore. Also, the openssl 4.0 gem now _freezes_ the `DEFAULT_PARAMS` hash. So this is needed for compatibility with both openssl 4.0 and ruby 4.0.
Contributor
Author
|
@chrisarcand Happy New Year! 😄 Any thoughts on this this PR (and #361, and #360)? This change is needed for compatibility with v4.0.0 of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OpenSSL::SSL::SSLContext#set_paramsmethod has had secure defaults since ruby 2.4 or 2.5. Since support for ruby versions prior to 3.1 has been dropped, there's no need to modify this anymore.Also, the openssl 4.0 gem now freezes the
DEFAULT_PARAMShash. So this is needed for compatibility with both openssl 4.0 and ruby 4.0.