Skip to content

returns request response #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sepowitz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

returns request response #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions addon/components/ember-chimp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ const {
A utility method for checking the end of a string
for a certain value.

@method endsWith
@param {String} string The string to check.
@method endsWith
@param {String} string The string to check.
@param {String} suffix The suffix to check the string for.
@private
@return {Boolean} A boolean that indicates whether the suffix is present.
*/
function endsWith(string, suffix) {
return string.indexOf(suffix, string.length - suffix.length) !== -1;
}

/**
The EmberChimp component provides a simple, flexible
email list signup form, specifically for integrating
Expand Down Expand Up @@ -72,7 +72,7 @@ export default Component.extend({

if (get(this, 'isLoading')) { return; }

if (get(this, 'value').length === 0) {
if (get(this, 'value').length === 0) {
this._triggerInvalid();
return;
}
Expand All @@ -81,17 +81,17 @@ export default Component.extend({
chimpState: 'loading',
chimpSays: get(this, 'loadingText')
});

let request = this.makeRequest(formAction)
.then(response => this.handleResponse(response))
.catch(() => this._triggerInvalid());
.catch(response => this._triggerInvalid(response));

if (this.get('didSubmitAction')) { this.sendAction('didSubmitAction', request); }
},

/**
An Overwritable Hook for building the request to Mailchimp.
Uses ember-ajax under the hood. If you'd like to use a
Uses ember-ajax under the hood. If you'd like to use a
different method to build this request, you can do so
by overriding this method.

Expand Down Expand Up @@ -120,12 +120,13 @@ export default Component.extend({
chimpState: response.result,
chimpSays: this._messageForResponse(response)
});
return response;
},

/**
Returns a user facing string for a response.

@method _messageForResponse
@method _messageForResponse
@private
@param {Object} response The response from the Mailchimp API.
@return {String} A string to display.
Expand All @@ -144,12 +145,13 @@ export default Component.extend({
@method _triggerInvalid
@private
*/
_triggerInvalid() {
_triggerInvalid(response) {
if (this.isDestroyed) { return; }
this.setProperties({
chimpSays: get(this, 'responses.invalidError'),
chimpState: 'error'
});
return response;
},

/**
Expand Down