Skip to content

Speedup countries #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixbuenemann wants to merge 2 commits into
base: 3-0-alpha
Choose a base branch
from
Open

Speedup countries #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667e62a
Speed up countries endpoint
felixbuenemann Mar 4, 2016
58af6e8
Allow selective loading of countries by ISO 3166-2
felixbuenemann Mar 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/controllers/spree/api/ams/countries_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@ class CountriesController < Spree::Api::CountriesController

# We don't need this paginated.
def index
@countries = Country.accessible_by(current_ability, :read).order('name ASC')
@countries = Country.accessible_by(current_ability, :read)
.includes(:states).order(:name)

isos = params[:isos]
isos = isos.split ',' if isos.is_a?(String)

@countries = @countries.where(iso: isos) if isos.present?

respond_with @countries
end

end
end
end
end
end
7 changes: 3 additions & 4 deletions app/serializers/spree/state_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ class StateSerializer < ActiveModel::Serializer

attributes :id,
:name,
:abbr

has_one :country, include: false
:abbr,
:country_id

end
end
end