Inept stubbing in ProjectsDataRepositoryTest

[chetdeva]

GithubTrending/Data/src/test/java/co/joebirch/data/ProjectsDataRepositoryTest.kt

Line 96 in 02ae6cd

private fun stubBookmarkProject(completable: Completable) {

Issue: 2 tests were failing

1. bookmarkProjectCompletes

You should be using factory.getCacheDataStore().setProjectAsBookmarked(any()) instead of cache.setProjectAsBookmarked(any())

private fun stubBookmarkProject(completable: Completable) {
       whenever(factory.getCacheDataStore().setProjectAsBookmarked(any())).thenReturn(completable)
}

2. unbookmarkProjectCompletes

Same

[arthlimchiu]

@chetdeva You can also do this

private fun stubBookmarkProject(completable: Completable) {
        whenever(store.setProjectAsBookmarked(any()))
                .thenReturn(completable)
    }

    private fun stubUnBookmarkProject(completable: Completable) {
        whenever(store.setProjectAsUnbookmarked(any()))
                .thenReturn(completable)
    }

Because stubbing for data stores are already handled in these methods

private fun stubFactoryGetDataStore() {
        whenever(factory.getDataStore(any(), any()))
                .thenReturn(store)
    }

    private fun stubFactoryGetCacheDataStore() {
        whenever(factory.getCacheDataStore())
                .thenReturn(store)
    }