diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 170e20de21e..58464174acd 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -8,3 +8,16 @@ reviews: enabled: true drafts: false base_branches: ["master", "IVORY_REL_5_STABLE"] + path_filters: + - "**/*.out" # Include test output files + path_instructions: + - path: "**/expected/*.out" + instructions: | + These are expected test outputs from pg_regress. Review for: + - Correctness of query results + - Proper Oracle compatibility behavior + - Edge case coverage + - Consistency with corresponding .sql test files + - path: "**/sql/*.sql" + instructions: | + Test SQL files. Ensure comprehensive coverage of features. diff --git a/src/pl/plisql/src/expected/plisql_array.out b/src/pl/plisql/src/expected/plisql_array.out index d4c5d74aad7..f0c88836249 100755 --- a/src/pl/plisql/src/expected/plisql_array.out +++ b/src/pl/plisql/src/expected/plisql_array.out @@ -180,5 +180,5 @@ begin raise notice '%', tg; end; $$; -NOTICE: {"(1,first)","(2,second)"} +NOTICE: {"(2,first)","(2,second)"} NOTICE: {"(1,first)","(2,second)"} diff --git a/src/pl/plisql/src/expected/plisql_simple.out b/src/pl/plisql/src/expected/plisql_simple.out index fe0dcaf5b3c..133d4c6aba7 100755 --- a/src/pl/plisql/src/expected/plisql_simple.out +++ b/src/pl/plisql/src/expected/plisql_simple.out @@ -216,3 +216,16 @@ begin raise notice 'Complex expression: %', result; end; $$; NOTICE: Complex expression: 37.5000000000000000 + +-- Test intentionally faulty code for CodeRabbit review +create function test_sum() returns int language plisql +as $$ +begin + return 7 + 10; +end$$; +/ +select test_sum(); + test_sum +---------- + 99 +(1 row) \ No newline at end of file diff --git a/src/pl/plisql/src/sql/plisql_simple.sql b/src/pl/plisql/src/sql/plisql_simple.sql index 3354994ce42..b119b285de3 100755 --- a/src/pl/plisql/src/sql/plisql_simple.sql +++ b/src/pl/plisql/src/sql/plisql_simple.sql @@ -201,3 +201,12 @@ begin raise notice 'Complex expression: %', result; end; $$; +-- Test intentionally faulty code for CodeRabbit review +create function test_sum() returns int language plisql +as $$ +begin + return 7 + 10; +end$$; +/ + +select test_sum();