Suggested Changes

[bradybus]

I am new to GitHub and code-sharing in general, so I am not sure how to go about suggesting edits, but I'll take a shot at it.

First of all, this set of code has been TREMENDOUSLY helpful. Previously we had been opening .tdms files in excel, and saving them as text files from there for importing into MATLAB. This was a very tedious process. So thank you!

I changed quite a bit of the 'simpleConvertTDMS' to fit the specific needs of our research lab at Brigham Young University. Along the way, I noticed several things that may, in my opinion, make this cleaner and/or more general.

One of these is to remove lines 112:116, replacing them with the MATLAB function 'matlab.lang.makeValidName()' and 'matlab.lang.makeUniqueStrings()'. As in:

safeChannelNameValid = matlab.lang.makeValidName(channelNames,'ReplacementStyle','delete','Prefix','d');
safeChannelName = matlab.lang.makeUniqueStrings(safeChannelNameValid);

The first would be used for calling structure fields, while the second would be used for making the new ones later on.

There are several other general changes I've made as well, but not sure how to go about suggesting them, as typing them all out here seems a bit of a hassle.

Let me know if I could submit all of my changes for review.
Thanks.

[humphreysb]

Thanks - I will take a look at your suggestion. for github, what you
would do is:

1. Create a "Pull Request" with any comments or suggestions instead of
   emailing them. Then when I incoprate the changes, I reference the pull
   request.
2. If you want to make the changes, you first clone and then fork my
   repository. Once you have made the changes, you or I merge the changes
   back into the repository.

I will take a look at your suggestion below. If you have others, please
feel free to do the pull request or fork.

Regards,

Brad

On 05/07/2015 11:30 AM, bradybus wrote:

I am new to GitHub and code-sharing in general, so I am not sure how
to go about suggesting edits, but I'll take a shot at it.

First of all, this set of code has been TREMENDOUSLY helpful.
Previously we had been opening .tdms files in excel, and saving them
as text files from there for importing into MATLAB. This was a very
tedious process. So thank you!

I changed quite a bit of the 'simpleConvertTDMS' to fit the specific
needs of our research lab at Brigham Young University. Along the way,
I noticed several things that may, in my opinion, make this cleaner
and/or more general.

One of these is to remove lines 112:116, replacing them with the
MATLAB function 'matlab.lang.makeValidName()' and
'matlab.lang.makeUniqueStrings()'. As in:

safeChannelNameValid =
matlab.lang.makeValidName(channelNames,'ReplacementStyle','delete','Prefix','d');
safeChannelName = matlab.lang.makeUniqueStrings(safeChannelNameValid);

The first would be used for calling structure fields, while the second
would be used for making the new ones later on.

There are several other general changes I've made as well, but not
sure how to go about suggesting them, as typing them all out here
seems a bit of a hassle.

Let me know if I could submit all of my changes for review.
Thanks.

—
Reply to this email directly or view it on GitHub
#4.