Skip to content

Decide on how to handle Glamor Rules #2

@ssomnoremac

Description

@ssomnoremac
  1. Idea is we need to separate Glamor Rules that are static from those that are not

static

(props) => ({color: props.green ? "green" : "#000"})

dynamic (animated or toggled styles)

(props) => ({top: props.topOffset ? props.topOffset : 0})

Am I right that these need to be handled differently or am I overthinking it. Should we just allow static rules and leave dynamic styles as styleProps or inlineStyles? If not, my suggestion (in master currently) was to have an extra param for dynamic

(props, d) => ({top: props.topOffset ? props.topOffset : 0})

but that's just so I can switch on param length. Seems hacky. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions