Refactoring Assertion Redundancy using helper functions

[kordusas]

Hello everyone,

I’ve been reviewing the code and noticed that there are several similar assertion blocks throughout. I wonder if we might consider refactoring these into helper functions (for example, _assert_type) to reduce redundancy and improve overall readability.

I believe this change could help streamline codebase and adhere more closely to the DRY principle. I’d be happy to contribute a pull request with these modifications if the team feels this is a beneficial improvement.

for example updating materials class adding assert method would already make this cleaner.

def _assert_type(value, expected_type, var_name):
    if not isinstance(value, expected_type):
        raise TypeError(f"{var_name} must be of type {expected_type.__name__}. {value} given.")

[MicahGale]

Yes this is in the long term plan. I'd suggest looking at: #91, and #393. If you want to volunteer, let's get a good implementation plan together :).

[MicahGale]

P.S. I edited your post to have code highlighting.

[MicahGale]

Update: we have started the branch alpha-test-checkvalue to start implementing this. #691 is where we are starting the infrastructure (decorators on this). The plan is to create the infrastructure and then finally implement it universally.

[MicahGale]

See #842.

[MicahGale]

This will be released with the next minor release.