Add `ISSUE_PREFIX` template variable and update templates

[NoahCardoza]

Summary

Make Handlebars templates provider-aware by adding an ISSUE_PREFIX template variable and updating all template files that reference issue IDs.

Context

Part of Epic #595. Templates currently hardcode # before {{ISSUE_NUMBER}}, producing incorrect output like Issue #QLH-4404 for Jira users.

Files to Modify

Template Infrastructure

• src/lib/PromptTemplateManager.ts — Add ISSUE_PREFIX?: string to TemplateVariables
• src/commands/ignite.ts — Set ISSUE_PREFIX in buildTemplateVariables() (derive from settings provider type: '#' for GitHub, '' for others)
• src/lib/ClaudeService.ts — Set ISSUE_PREFIX where template variables are built

Template Files

Replace Issue #{{ISSUE_NUMBER}} with Issue {{ISSUE_PREFIX}}{{ISSUE_NUMBER}} in:

• templates/prompts/issue-prompt.txt (~6 instances)
• templates/agents/iloom-issue-implementer.md
• templates/agents/iloom-issue-planner.md
• templates/agents/iloom-issue-analyzer.md
• templates/agents/iloom-issue-analyze-and-plan.md (if exists)
• templates/agents/iloom-issue-complexity-evaluator.md
• templates/agents/iloom-issue-enhancer.md

Acceptance Criteria

• ISSUE_PREFIX added to TemplateVariables type
• ISSUE_PREFIX populated correctly in ignite.ts and ClaudeService.ts
• All #{{ISSUE_NUMBER}} occurrences in templates replaced with {{ISSUE_PREFIX}}{{ISSUE_NUMBER}}
• GitHub users see Issue #123 (no regression)
• Jira users see Issue QLH-4404 (no # prefix)
• Linear users see Issue ENG-123 (no # prefix)
• pnpm build passes
• pnpm test passes

Dependencies

• Blocked by: Add formatIssueId to IssueTracker interface and IssueTrackerFactory #596 (Add formatIssueId interface and implementations)

[acreeger]

Starting automated workflow for this issue.

[acreeger]

Codebase Analysis

The template system uses Handlebars-based variable substitution via PromptTemplateManager. Template variables are built in two key locations: ignite.ts (buildTemplateVariables()) for the spin workflow and ClaudeService.ts (launchForWorkflow()) for the start workflow. The IssueTrackerFactory already has a getProviderName() static method that returns the provider type from settings, and a formatIssueId() method. There are 24 occurrences of #{{ISSUE_NUMBER}} across 8 template files that need updating.

Full Analysis

Key Files

1. src/lib/PromptTemplateManager.ts - Defines TemplateVariables interface (lines 16-105) and the template compilation engine. ISSUE_PREFIX needs to be added to this interface.

2. src/commands/ignite.ts - The buildTemplateVariables() method (lines 473-540) builds variables for the il spin command. Needs to derive ISSUE_PREFIX from settings provider type using IssueTrackerFactory.getProviderName().

3. src/lib/ClaudeService.ts - The launchForWorkflow() method (lines 64-170) builds variables for the il start command. Needs the same ISSUE_PREFIX logic.

4. src/lib/IssueTrackerFactory.ts - Already has getProviderName() (line 88) and formatIssueId() (line 69) which provide the foundation. The prefix logic is simple: '#' for GitHub, '' for Linear/Jira.

Template Files with #{{ISSUE_NUMBER}}

• templates/prompts/issue-prompt.txt - 12 occurrences
• templates/prompts/session-summary-prompt.txt - 1 occurrence
• templates/agents/iloom-issue-implementer.md - 2 occurrences
• templates/agents/iloom-issue-planner.md - 2 occurrences
• templates/agents/iloom-issue-analyzer.md - 2 occurrences
• templates/agents/iloom-issue-analyze-and-plan.md - 2 occurrences
• templates/agents/iloom-issue-complexity-evaluator.md - 2 occurrences
• templates/agents/iloom-issue-enhancer.md - 2 occurrences

Provider Logic

The IssueTrackerFactory.getProviderName() returns 'github' | 'linear' | 'jira'. For GitHub, the prefix should be '#'. For Linear and Jira, the prefix should be '' (empty string since identifiers like ENG-123 or QLH-4404 already contain their format).

Settings Access

Both ignite.ts and ClaudeService.ts have access to settings. In ignite.ts, this.settings is loaded by Step 2.0.5. In ClaudeService.ts, settings are loaded via this.settingsManager.loadSettings().

[acreeger]

Implementation Plan

The approach is straightforward: add ISSUE_PREFIX to the template variables type, populate it in both variable-building locations based on the configured issue tracker provider, then do a global search-and-replace in all template files. GitHub gets #, Linear and Jira get empty string.

Full Plan

Step 1: Add ISSUE_PREFIX to TemplateVariables type

• File: src/lib/PromptTemplateManager.ts
• Add ISSUE_PREFIX?: string to the TemplateVariables interface

Step 2: Set ISSUE_PREFIX in ignite.ts

• File: src/commands/ignite.ts
• In buildTemplateVariables(), after existing variable setup, add:
  • Get provider name via IssueTrackerFactory.getProviderName(this.settings)
  • Set ISSUE_PREFIX to '#' for github, '' for linear/jira
• Import IssueTrackerFactory (already imported in ignite.ts)

Step 3: Set ISSUE_PREFIX in ClaudeService.ts

• File: src/lib/ClaudeService.ts
• In launchForWorkflow(), after existing variable setup, add the same prefix logic
• Import IssueTrackerFactory and IssueTrackerProviderType

Step 4: Update template files

Replace all #{{ISSUE_NUMBER}} with {{ISSUE_PREFIX}}{{ISSUE_NUMBER}} in:

• templates/prompts/issue-prompt.txt (12 occurrences)
• templates/prompts/session-summary-prompt.txt (1 occurrence)
• templates/agents/iloom-issue-implementer.md (2 occurrences)
• templates/agents/iloom-issue-planner.md (2 occurrences)
• templates/agents/iloom-issue-analyzer.md (2 occurrences)
• templates/agents/iloom-issue-analyze-and-plan.md (2 occurrences)
• templates/agents/iloom-issue-complexity-evaluator.md (2 occurrences)
• templates/agents/iloom-issue-enhancer.md (2 occurrences)

Step 5: Build and test

• Run pnpm build to verify TypeScript compiles
• Run pnpm test to verify no regressions

Expected behavior

• GitHub users: ISSUE_PREFIX='#' → templates render Issue #123
• Linear users: ISSUE_PREFIX='' → templates render Issue ENG-123
• Jira users: ISSUE_PREFIX='' → templates render Issue QLH-4404

[acreeger]

Plan Review (Gemini)

Verdict: approved with minor refinement

Gemini identified a valid DRY concern: the prefix derivation logic would be duplicated in ignite.ts and ClaudeService.ts. To address this, I'll add a static getIssuePrefix() helper to IssueTrackerFactory that centralizes the prefix logic. No critical issues found.

Full Review

Key findings:

• DRY concern (medium): Prefix derivation duplicated in two places. Refinement: add IssueTrackerFactory.getIssuePrefix(providerType) static method.
• Low-risk assessment: The change defaults GitHub to #, ensuring no regression for existing users.
• Type safety: Adding to TemplateVariables interface ensures compile-time checking.
• No security concerns identified for this string-substitution change.

[acreeger]

Implementation Complete

Added ISSUE_PREFIX template variable with centralized helper IssueTrackerFactory.getIssuePrefix(). The prefix is # for GitHub and empty string for Linear/Jira. Updated all 24 occurrences of #{{ISSUE_NUMBER}} across 8 template files to use {{ISSUE_PREFIX}}{{ISSUE_NUMBER}}. Fixed 5 test assertions in ClaudeService.test.ts to expect the new variable. Build and all 3835 tests pass.

Full Implementation Log

Files Modified

Infrastructure:

• src/lib/PromptTemplateManager.ts - Added ISSUE_PREFIX?: string to TemplateVariables interface
• src/lib/IssueTrackerFactory.ts - Added getIssuePrefix(providerType) static helper method
• src/commands/ignite.ts - Set ISSUE_PREFIX in buildTemplateVariables() using IssueTrackerFactory.getIssuePrefix()
• src/lib/ClaudeService.ts - Set ISSUE_PREFIX in launchForWorkflow() using IssueTrackerFactory.getIssuePrefix()

Template Files (replaced #{{ISSUE_NUMBER}} with {{ISSUE_PREFIX}}{{ISSUE_NUMBER}}):

• templates/prompts/issue-prompt.txt (12 occurrences)
• templates/prompts/session-summary-prompt.txt (1 occurrence)
• templates/agents/iloom-issue-implementer.md (2 occurrences)
• templates/agents/iloom-issue-planner.md (2 occurrences)
• templates/agents/iloom-issue-analyzer.md (2 occurrences)
• templates/agents/iloom-issue-analyze-and-plan.md (2 occurrences)
• templates/agents/iloom-issue-complexity-evaluator.md (2 occurrences)
• templates/agents/iloom-issue-enhancer.md (2 occurrences)

Test Fix:

• src/lib/ClaudeService.test.ts - Updated 5 assertions to include ISSUE_PREFIX: '#'

Verification

• pnpm build passes
• pnpm test passes (116 test files, 3835 tests, 0 failures)

[acreeger]

Code Review (Gemini)

Result: clean - 0 critical/high/medium issues

Gemini found no bugs, security, or performance issues. One low-severity suggestion to encapsulate the settings-to-prefix resolution into a single factory method. The current approach is fine since the duplication is minimal (one-liner in two places) and follows the same pattern used throughout the codebase.

Full Code Review

Findings:

• Low: Minor duplication of this.settings ? IssueTrackerFactory.getProviderName(...) : 'github' in two files. Acceptable given the minimal scope.
• No critical, high, or medium issues found.
• Type safety is good via IssueTrackerProviderType.
• No injection risks - prefixes are hardcoded static strings.
• Template changes are consistent and complete.

Improvement suggestions (deferred):

• Could accept settings? directly in getIssuePrefix() to centralize the fallback logic
• Could use a FORMATTED_ISSUE_ID variable for more complex future formatting needs

Both are valid future considerations but not needed for this PR's scope.

[acreeger]

Implementation complete. Changes committed with fixes #601.

[acreeger]

Implemented on branch epic/595