From ceb83370f18470de17f29da23f7dd3a8eef9c2a5 Mon Sep 17 00:00:00 2001 From: jaysonv0341 Date: Mon, 13 Oct 2025 16:28:11 -0600 Subject: [PATCH] Fix: Remove conditional checks on secrets in reusable workflow Secrets cannot be accessed in conditional expressions in reusable workflows. Instead, use continue-on-error to allow the GitHub App token step to fail gracefully if APP_ID/APP_PRIVATE_KEY aren't provided. The action will fall back to using GITHUB_TOKEN if the app token isn't available. --- .github/workflows/claude-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/claude-review.yml b/.github/workflows/claude-review.yml index 3551d67..a14222f 100644 --- a/.github/workflows/claude-review.yml +++ b/.github/workflows/claude-review.yml @@ -44,7 +44,7 @@ jobs: # (Optional) Generate a GitHub App token for better commenting behavior - name: Generate GitHub App token id: app-token - if: ${{ secrets.APP_ID != '' && secrets.APP_PRIVATE_KEY != '' }} + continue-on-error: true uses: actions/create-github-app-token@v2 with: app-id: ${{ secrets.APP_ID }}