Skip to content

[pending] hard drop it is not going all the way down if the piece grid (4x4) has empy rows at the end #3

@itssimmons

Description

@itssimmons

e.g:

for this tetromino

* * ■ *
■ ■ ■ *
* * * * <- empty row
* * * * <- empty row

The hard drop will be place the piece somewhere close to this:

* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * * * * * *
* * * * * ■ * * * *
* * * ■ ■ ■ * * * *
* * * * * * * * * * <- 
* * * * * * * * * * <- these are the 2 last empty rows

In theory, the hard drop is based on the highest baseline possible for the currentShape, but there are moments where the piece doesn't go all the way down. My intuition is this.


This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #3 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @itssimmons (replace 20 with the amount, and @itssimmons with the user to tip).

📖 If you want to learn more, check out our documentation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions