-
Notifications
You must be signed in to change notification settings - Fork 118
Description
I suspect what is happening:
-
A Go application accesses the mount
-
The application raises
SIGURGsignals due to a Go feature introduced in 1.14 for non-cooperative goroutine preemption -
FUSE handles the signal and raises an INTERRUPT:
If a process issuing a FUSE filesystem request is interrupted, the following will happen:
- If the request is not yet sent to userspace AND the signal is fatal (SIGKILL or unhandled fatal signal), then the request is dequeued and returns immediately.
- If the request is not yet sent to userspace AND the signal is not fatal, then an interrupted flag is set for the request. When the request has been successfully transferred to userspace and this flag is set, an INTERRUPT request is queued.
- If the request is already sent to userspace, then an INTERRUPT request is queued.
-
The
InterruptOpis being handled and cancels the operation -
This cancels the context which is passed to the HTTP request to GCS resulting in errors such as:
2022/05/25 15:20:21.417866 LookUpInode: operation canceled, clobbered: StatObject: not retrying StatObject("filename.example"): Get "https://storage.googleapis.com:443/storage/v1/b/example/o/filename.example?projection=full": net/http: request canceled fuse: 2022/05/25 15:20:21.417893 *fuseops.LookUpInodeOp error: operation canceled
Others, such as Docker and Gitea, have solved this by filtering out the SIGURG as referenced in golang/go#37942 . However as far as I can tell there's no option to ignore the SIGURG since it's FUSE which is handling them, and by the time it reaches this library as an interrupt the context is lost.
Our current workaround is to set GODEBUG="asyncpreemptoff=1" for the applications which use gcsfuse mounts.
Whilst the issue is happening whilst using gcsfuse I think the solution lies in this package but please let me know if that's not right. Happy to create a PR for this but I'm not entirely sure how to solve it. Can you think of any solutions for this as it seems like more people are running into this issue: GoogleCloudPlatform/gcsfuse#288 GoogleCloudPlatform/gcsfuse#562 ?