From 3e7cc96d694cbd40b30d3433e248ddf161f4a001 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 19 Nov 2024 11:51:01 -0500
Subject: [PATCH 1/4] remove legacy inline onClick handler in
 AbstractPlotPublisher/config.jelly

---
 .../hudson/plugins/plot/AbstractPlotPublisher/config.jelly   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly b/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
index a137def..93ac3d5 100644
--- a/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
@@ -66,9 +66,8 @@
         <f:entry title="" description="${%A new data series definition}">
           <f:repeatable var="series" items="${plot.series}" minimum="1">
             <div>
-              <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
-                <f:textbox name="file" value="${series.file}"
-                           checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+              <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
+                <f:textbox name="file" value="${series.file}"/>
               </f:entry>
 
               <f:radioBlock name="fileType" value="properties" title="${%Load data from properties file}" help="/plugin/plot/help-properties.html" checked="${series.fileType=='properties' or series.fileType==null}">

From 32543ea8316911463851db9767dd739ced9b16cb Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 19 Nov 2024 12:49:50 -0500
Subject: [PATCH 2/4] remove legacy inline onClick handlers

---
 .../resources/hudson/plugins/plot/CSVSeries/config.jelly     | 5 ++---
 .../hudson/plugins/plot/PropertiesSeries/config.jelly        | 5 ++---
 .../resources/hudson/plugins/plot/XMLSeries/config.jelly     | 5 ++---
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
index 53f94a2..58e51ab 100644
--- a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
@@ -3,9 +3,8 @@
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
         <div>
-            <f:entry title="${%Data series file}" field="file" help="/plugin/plot/help-series.html">
-                <f:textbox name="file" value="${series.file}"
-                           checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)"/>
+            <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
+                <f:textbox name="file" value="${series.file}"/>
             </f:entry>
             <f:nested>
                 <div>
diff --git a/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly b/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
index 8b700a0..60afd97 100644
--- a/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
@@ -2,9 +2,8 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
     <div>
-    <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
-        <f:textbox name="file" value="${series.file}"
-                   checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+    <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
+        <f:textbox name="file" value="${series.file}"/>
     </f:entry>
         <f:nested>
             <f:entry title="${%Data series legend label}" help="/plugin/plot/help-legend.html">
diff --git a/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly b/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
index 8d89d5d..9606990 100644
--- a/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
@@ -2,9 +2,8 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
     <div>
-    <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
-        <f:textbox name="file" value="${series.file}"
-                   checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+    <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
+        <f:textbox name="file" value="${series.file}"/>
     </f:entry>
         <f:nested>
             <div>

From 88173370349780033f2ddc2309a7c6a9fa093a86 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 21 Nov 2024 10:34:09 -0500
Subject: [PATCH 3/4] use checkDepends on for Pipeline compatibility

---
 .../resources/hudson/plugins/plot/CSVSeries/config.jelly    | 6 ++++--
 .../hudson/plugins/plot/PropertiesSeries/config.jelly       | 6 ++++--
 .../resources/hudson/plugins/plot/XMLSeries/config.jelly    | 6 ++++--
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
index 58e51ab..50d02d2 100644
--- a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
@@ -3,8 +3,10 @@
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
         <div>
-            <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
-                <f:textbox name="file" value="${series.file}"/>
+            <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
+                <f:textbox name="file" value="${series.file}"
+                           checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                           checkDependsOn="" />
             </f:entry>
             <f:nested>
                 <div>
diff --git a/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly b/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
index 60afd97..cd9c908 100644
--- a/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
@@ -2,8 +2,10 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
     <div>
-    <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
-        <f:textbox name="file" value="${series.file}"/>
+    <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
+        <f:textbox name="file" value="${series.file}"
+                   checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                   checkDependsOn="" />
     </f:entry>
         <f:nested>
             <f:entry title="${%Data series legend label}" help="/plugin/plot/help-legend.html">
diff --git a/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly b/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
index 9606990..3ebdf8f 100644
--- a/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
@@ -2,8 +2,10 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
     <div>
-    <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
-        <f:textbox name="file" value="${series.file}"/>
+    <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
+        <f:textbox name="file" value="${series.file}"
+                   checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                   checkDependsOn="" />
     </f:entry>
         <f:nested>
             <div>

From 22b0d47ba5258a7506a3da8f091316ad27319f7c Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 21 Nov 2024 10:35:05 -0500
Subject: [PATCH 4/4] use checkDepends on for Pipeline compatibility

---
 src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
index 50d02d2..2eab7ae 100644
--- a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
+++ b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
@@ -3,7 +3,7 @@
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:entry>
         <div>
-            <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
+            <f:entry title="${%Data series file}" field="file" help="/plugin/plot/help-series.html">
                 <f:textbox name="file" value="${series.file}"
                            checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
                            checkDependsOn="" />