Skip to content
This repository was archived by the owner on Jun 28, 2022. It is now read-only.

Commit 585f7b8

Browse files
committed
runat-1128988: Clarify some comments
Signed-off-by: Joe Walker <jwalker@mozilla.com>
1 parent 5408bc6 commit 585f7b8

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

lib/gcli/system.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,13 @@ function addLocalFunctions(specs, front) {
290290
// all the remote types
291291
specs.forEach(function(commandSpec) {
292292
// HACK: Tack the front to the command so we know how to remove it
293-
// in syncItems() below
293+
// in syncItems() above
294294
commandSpec.front = front;
295295

296-
// TODO: syncItems() doesn't remove types, so do we need this?
296+
// Tell the type instances for a command how to contact their counterparts
297+
// Don't confuse this with setting the front on the commandSpec which is
298+
// about associating a proxied command with it's source for later removal.
299+
// This is actually going to be used by the type
297300
commandSpec.params.forEach(function(param) {
298301
if (typeof param.type !== 'string') {
299302
param.type.front = front;

lib/gcli/types/delegate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ exports.items = [
9090
stringify: function(value, context) {
9191
// remote types are client only, and we don't attempt to transfer value
9292
// objects to the client (we can't be sure the are jsonable) so it is a
93-
// but strange to be asked to stringify a value object, however since
93+
// bit strange to be asked to stringify a value object, however since
9494
// parse creates a Conversion with a (fake) value object we might be
9595
// asked to stringify that. We can stringify fake value objects.
9696
if (typeof value.stringified === 'string') {

lib/gcli/types/types.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,8 +947,8 @@ function Type() {
947947

948948
/**
949949
* Get a JSONable data structure that entirely describes this type.
950-
* commandName and paramName are the names of the command and parameter which we
951-
* are remoting to help the server get back to the remoted action.
950+
* commandName and paramName are the names of the command and parameter which
951+
* we are remoting to help the server get back to the remoted action.
952952
*/
953953
Type.prototype.getSpec = function(commandName, paramName) {
954954
throw new Error('Not implemented');

0 commit comments

Comments
 (0)