From d179de4be879e14c38697e0b8f5d997ce3c1ee8c Mon Sep 17 00:00:00 2001 From: Girt Date: Mon, 29 Oct 2012 15:12:38 +0400 Subject: [PATCH 1/4] Update classes/breadcrumbs.php fix render function: echo/retrurn switch --- classes/breadcrumbs.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/breadcrumbs.php b/classes/breadcrumbs.php index 71bf3c4..16d2af7 100644 --- a/classes/breadcrumbs.php +++ b/classes/breadcrumbs.php @@ -42,6 +42,6 @@ public static function add(Breadcrumb $crumb) */ public static function render($template = "breadcrumbs/layout") { - echo View::factory($template)->set('breadcrumbs', self::$breadcrumbs)->render(); + return View::factory($template)->set('breadcrumbs', self::$breadcrumbs)->render(); } } \ No newline at end of file From f345181a3012175240fad25925558ba64e529edb Mon Sep 17 00:00:00 2001 From: Girt Date: Sun, 10 Feb 2013 20:40:32 +0400 Subject: [PATCH 2/4] PSR-0 support --- classes/{breadcrumb.php => Breadcrumb.php} | 0 classes/{breadcrumb/exception.php => Breadcrumb/Exception.php} | 0 classes/{breadcrumbs.php => Breadcrumbs.php} | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename classes/{breadcrumb.php => Breadcrumb.php} (100%) rename classes/{breadcrumb/exception.php => Breadcrumb/Exception.php} (100%) rename classes/{breadcrumbs.php => Breadcrumbs.php} (100%) diff --git a/classes/breadcrumb.php b/classes/Breadcrumb.php similarity index 100% rename from classes/breadcrumb.php rename to classes/Breadcrumb.php diff --git a/classes/breadcrumb/exception.php b/classes/Breadcrumb/Exception.php similarity index 100% rename from classes/breadcrumb/exception.php rename to classes/Breadcrumb/Exception.php diff --git a/classes/breadcrumbs.php b/classes/Breadcrumbs.php similarity index 100% rename from classes/breadcrumbs.php rename to classes/Breadcrumbs.php From 09b94f7a88d7c52307a4ca7f9a7f036656328649 Mon Sep 17 00:00:00 2001 From: Dennis Ruhe Date: Sun, 21 Apr 2013 12:57:17 +0200 Subject: [PATCH 3/4] Added params to factory to simplify adding breadcrumb --- classes/Breadcrumb.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/classes/Breadcrumb.php b/classes/Breadcrumb.php index fd76f0f..bf4f3ad 100644 --- a/classes/Breadcrumb.php +++ b/classes/Breadcrumb.php @@ -20,9 +20,13 @@ class Breadcrumb /** * Breadcrumb Factory */ - public static function factory() + public static function factory($title = '', $url = '') { - return new Breadcrumb; + $crumb = new Breadcrumb(); + $crumb->set_title($title); + $crumb->set_url($url); + + return $crumb; } /** From d46f925ff477e17a37f396a8064793fb97824ee5 Mon Sep 17 00:00:00 2001 From: Dennis Ruhe Date: Sun, 21 Apr 2013 12:57:49 +0200 Subject: [PATCH 4/4] Improved compatability of layout.php --- views/breadcrumbs/layout.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/views/breadcrumbs/layout.php b/views/breadcrumbs/layout.php index d2b8aaa..6177676 100644 --- a/views/breadcrumbs/layout.php +++ b/views/breadcrumbs/layout.php @@ -5,14 +5,14 @@ * @author Kieran Graham */ ?> - 0) : ?> + 0) : ?> - \ No newline at end of file + \ No newline at end of file