[build] Cannot run cargo test and cargo fetch

[yuioto]

cargo test

According to archwiki, I need to run cargo test.

pkgname=fav-git
_pkgname="${pkgname%-git}"

cd "$_pkgname"
export RUSTUP_TOOLCHAIN=stable
cargo test --frozen --all-features --workspace

Copy from https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=fav-git&id=efd4a6aa9cc4fe79fc4b63bbe19881b8def71b2b#n39

fav_cargo_test_err.log

So, I need help. If this process is too cumbersome or not runnable on the user's computer, I might consider removing check().

cargo fetch

cargo fetch --locked --target "$CARCH-unknown-linux-gnu"

Copy from https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=fav-git&id=efd4a6aa9cc4fe79fc4b63bbe19881b8def71b2b#n27

error: the lock file /tmp/fav-git/src/fav/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

If you are always required to synchronize lock files and toml files, it may burden you, so please consider carefully.

[kingwingfly]

Test

I haven't written any test yet. The tests now existing are used for developing, some of them are just for printing data that has been converted into protobuf, and others need fav init in workspace.

I'll add some test_utils in the future.

Fetch

I'll commit Cargo.lock then.

[yuioto]

Can Cargo.lock match toml every time it is committed? Otherwise I still need cargo fetch. Because I'm building from source(git).

In other words, test should be able to be used, but not now.

[kingwingfly]

I'm not familiar with arch Linux or its publishing.

All I searched told me, just commit Cargo.lock for binaries and don't for crates.

Please directly tell me how can I help with this. Or should I just run cargo fetch --lock in ci to ensure this command is runnable?

[yuioto]

All I searched told me, just commit Cargo.lock for binaries and don't for crates.

Yes, please see:

Note: If building a VCS package for an upstream source project that does not keep its Cargo.lock file in sync with Cargo.toml between release cycles, add cargo update before running cargo fetch. All other aspects of the build should work as documented here, although the result will not be a fully reproducible build because the dependencies will be resolved at build time.

Chinese translation:

注意： 在为上游源项目构建 VCS 软件包时，如果该项目在发布周期之间未保持 Cargo.lock 文件与 Cargo.toml 同步，请在运行 cargo fetch 之前添加 cargo update 。尽管结果并非完全可重现，但有关构建的其他所有方面都应符合上述内容，因为依赖关系将在构建时得到解决。

So, you only keep its Cargo.lock file in sync with Cargo.toml between release cycles(each commit).

Usually this can be done by simply running cargo update.

But when running cargo update, things you don't want may happen. Generally speaking, just running cargo build is enough.

Once you modify the code, pay attention to whether cargo.lock has been changed. If it has also been changed, please submit it together instead of just submitting the modified file.

Please directly tell me how can I help with this. Or should I just run cargo fetch --lock in ci to ensure this command is runnable?

This might be a good idea.

In fact, if you don't care about reproducible builds, you don't have to submit any Cargo.lock at all.

I'm opening this discussion just to ask for opinions.