From acced4df2c41c9c35ca9f0c3d9879769e58eea23 Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 12 Nov 2025 00:31:19 +0100 Subject: [PATCH 1/2] Mark dead code branch as unreachable --- include/argparse.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index 331daef..62cadd8 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -1482,9 +1482,9 @@ namespace argparse return CountAction(); case append: return AppendAction(); - default: - return StoreAction(); } + + std::unreachable(); } private: From d5186a9df2d9abfeabc671cdbb9d0f5623f116f1 Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 12 Nov 2025 00:31:30 +0100 Subject: [PATCH 2/2] Mark dead code branch as unreachable --- include/argparse.hpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index 62cadd8..0573415 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -1869,12 +1869,11 @@ namespace argparse static auto format_nargs(Formattable const & argument) -> std::string { - auto result = std::string(); auto const formatted_arg = format_arg(argument); if (argument.has_nargs_number()) { - result += std::ranges::fold_left(std::views::repeat(" " + formatted_arg, argument.get_nargs_number()), std::string(), std::plus()); + return std::ranges::fold_left(std::views::repeat(" " + formatted_arg, argument.get_nargs_number()), std::string(), std::plus()); } else { @@ -1887,9 +1886,9 @@ namespace argparse case one_or_more: return std::format(" {0} [{0} ...]", formatted_arg); } - } - return result; + std::unreachable(); + } } static auto help_string_separation(std::size_t help_line_length) -> std::string_view