Skip to content

Exec Prober doesn't use the timeout  #16

@Legion2

Description

@Legion2

For executing Probes, there is a timeout given, which is used by the HTTPGet, HTTPPost and TCPSocket probe but not by the Exec probe. This may result in endless blocking invocation if the probe never returns or something causes it to run very long.

prober/probe/prober.go

Lines 85 to 88 in 7208ea3

func (pb *Prober) executeProbe(p *api_v1.Handler, pod *core.Pod, timeout time.Duration) error {
if p.Exec != nil {
log.Debugf("Exec-Probe Pod: %v, Container: %v, Command: %v", formatPod(pod), p.ContainerName, p.Exec.Command)
res, resp, err := pb.Exec.Probe(pb.Config, pod, p.ContainerName, p.Exec.Command)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions