Skip to content

Warnings observed while building Cardinal #19

@cosinekitty

Description

@cosinekitty

Hi Ken! I see you all the time on the VCV Rack forum, but this is my first time saying hi on GitHub.

This morning while building Cardinal to submit a PR there for a Sapphire plugin update, I noticed some build warnings. I'm reporting this in case you find it helpful, not because the warnings are causing me any problems. These were the only warnings from Meander code.

Compiling Meander/src/Meander.cpp
Meander/src/Meander.cpp: In member function ‘void MeanderWidget::CircleOf5thsDisplay::updatePanel(const rack::widget::Widget::DrawArgs&)’:
Meander/src/Meander.cpp:5904:65: warning: ‘           ’ directive output may be truncated writing 11 bytes into a region of size between 1 and 128 [-Wformat-truncation=]
 5904 |                                 snprintf(text, sizeof(text), "%s           ",  module->theActiveHarmonyType.harmony_degrees_desc);
      |                                                                 ^~~~~~~~~~~
Meander/src/Meander.cpp:5904:41: note: ‘snprintf’ output between 12 and 139 bytes into a destination of size 128
 5904 |                                 snprintf(text, sizeof(text), "%s           ",  module->theActiveHarmonyType.harmony_degrees_desc);
      |                                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions