Torch dependency

[cdicle-motional]

@krrish94 Your package depends on the torch library but it is not listed in setup.py. Can you add that dependency to your setup.py?

[krrish94]

@cdicle-nutonomy This is an intentional omission -- the reason being everyone prefers using a different version of pytorch (based on their python/conda/pip/cuda configs)

[krrish94]

Your point is well-taken though. We'll improve our messaging in the README to better articulate this pytorch dependency

[cdicle-motional]

@krrish94 I think you can put something like

setup(
    ...
    install_requires=[
        ...
        'torch ~= 1.0 ;',
        ...
    ],
    ...
)

which should cover practically all torch versions but at least inform pip that the package depends on torch.

[krrish94]

This is a great point

[GordonGustafson]

Since the setup.py file currently requires torch, I don't think adding install_requires to setup.py will fix the issue, as the setup.py can't even be run until torch is installed.

The ideal solution is for wheels to be published to pypi, so the package can be installed without running setup.py. @krrish94 do you think that would be possible?