From 3d38d1e8043268d6028b1ba1e464b548480163ac Mon Sep 17 00:00:00 2001 From: cpcgoogle <32122848+cpcgoogle@users.noreply.github.com> Date: Mon, 16 Nov 2020 14:38:01 -0800 Subject: [PATCH] Update gcpserving.py pod_template_spec is a required field in deploy() but it looks like the parameter is never used. Maybe default to making it an empty string so users are not confused at what should be passed in to run the deployment. --- kubeflow/fairing/deployers/gcp/gcpserving.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kubeflow/fairing/deployers/gcp/gcpserving.py b/kubeflow/fairing/deployers/gcp/gcpserving.py index d5f919bf..3233512c 100644 --- a/kubeflow/fairing/deployers/gcp/gcpserving.py +++ b/kubeflow/fairing/deployers/gcp/gcpserving.py @@ -26,7 +26,7 @@ def __init__(self, model_dir, model_name, version_name, project_id=None, if 'python_version' not in self._deploy_kwargs: self._deploy_kwargs['python_version'] = '3.5' - def deploy(self, pod_template_spec): + def deploy(self, pod_template_spec = ""): """Deploys the model to Cloud ML Engine. :param pod_template_spec: pod spec template of training job