Skip to content

chore: Override PHP default changelog sections #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 1 commit into from
Feb 4, 2026
Merged

chore: Override PHP default changelog sections #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ jobs:
steps:
- uses: googleapis/release-please-action@v4
id: release
with:
command: manifest
Copy link
Contributor Author

@jsonbailey jsonbailey Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options are all detected by default and not needed. The last one isn't a valid option for v4 but is also automatically detected.

token: ${{ secrets.GITHUB_TOKEN }}
default-branch: main

- uses: actions/checkout@v4
if: ${{ steps.release.outputs.releases_created == 'true' }}
Expand Down
4 changes: 4 additions & 0 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"versioning": "default",
"include-v-in-tag": false,
"include-component-in-tag": false,
"changelog-sections": [
Copy link
Contributor Author

@jsonbailey jsonbailey Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The php release type is one of only a few release types that has a default changelog section if one is not provided. This breaks the norm with our other sdks and includes chores in releases which we typically don't do.

{"type": "feat", "section": "Features"},
{"type": "fix", "section": "Bug Fixes"}
],
"extra-files": [
".github/actions/build-docs/action.yml",
"src/LaunchDarkly/LDClient.php"
Expand Down