fix: Calculators prohibit input of Chinese text.#189
Open
JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
Open
fix: Calculators prohibit input of Chinese text.#189JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
log: Optimize filtering rules to exclude Chinese bug: https://pms.uniontech.com/bug-view-344067.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestricts calculator input filtering to allow only digits, ASCII English letters, and a defined set of operator/symbol characters, explicitly excluding Chinese characters that were previously admitted via QChar::isLetter(). Class diagram for InputEdit with updated handleTextChanged filteringclassDiagram
class InputEdit {
+void handleTextChanged(text: QString)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这段代码进行审查：
改进建议：
static const QString allowedStatic = QString::fromUtf8("＋－×÷.,%()/:^!");
bool isEnglishLetter = (ch.unicode() >= 'A' && ch.unicode() <= 'Z') ||
(ch.unicode() >= 'a' && ch.unicode() <= 'z');
bool InputEdit::isAllowedChar(const QChar& ch) const {
bool isEnglishLetter = (ch.unicode() >= 'A' && ch.unicode() <= 'Z') ||
(ch.unicode() >= 'a' && ch.unicode() <= 'z');
return ch.isDigit() || isEnglishLetter || allowedStatic.contains(ch) ||
decSym.contains(ch) || grpSym.contains(ch);
}
总体来说，这段代码质量良好，改进建议主要是为了提高代码的可维护性和性能。 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The ASCII range check for English letters works but is a bit ad hoc; consider using
ch.isLatin1()combined withch.isLetter()(and possibly an explicitQChar::Script_Latincheck if available) to more clearly and robustly express the intent to allow only Latin letters while excluding Chinese. - To avoid duplicating this logic if similar filtering is needed elsewhere, you might extract the "is allowed character" check into a small helper function or lambda, which will also make the loop body easier to read.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The ASCII range check for English letters works but is a bit ad hoc; consider using `ch.isLatin1()` combined with `ch.isLetter()` (and possibly an explicit `QChar::Script_Latin` check if available) to more clearly and robustly express the intent to allow only Latin letters while excluding Chinese.
- To avoid duplicating this logic if similar filtering is needed elsewhere, you might extract the "is allowed character" check into a small helper function or lambda, which will also make the loop body easier to read.
## Individual Comments
### Comment 1
<location> `src/widgets/inputedit.cpp:551-552` </location>
<code_context>
filtered.reserve(reformatStr.size());
for (const QChar &ch : std::as_const(reformatStr)) {
- if (ch.isDigit() || ch.isLetter() || allowedStatic.contains(ch) || decSym.contains(ch) || grpSym.contains(ch)) {
+ bool isEnglishLetter = (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');
+ if (ch.isDigit() || isEnglishLetter || allowedStatic.contains(ch) || decSym.contains(ch) || grpSym.contains(ch)) {
filtered.append(ch);
}
</code_context>
<issue_to_address>
**question:** Clarify whether restricting letters to ASCII only is intentional; consider whether extended Latin letters should be accepted.
This change now only accepts ASCII A–Z/a–z and rejects extended Latin characters like `é`, `ø`, `ß` or full-width Latin letters that `ch.isLetter()` previously allowed. If non-ASCII Latin input is expected, consider a broader condition (e.g. `QChar::isLatin1()` or another Unicode-aware check) rather than a pure ASCII range.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lzwind
approved these changes
Dec 29, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
TAG Bot New tag: 6.5.32 |
Contributor
|
TAG Bot New tag: 6.5.33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log: Optimize filtering rules to exclude Chinese
bug: https://pms.uniontech.com/bug-view-344067.html
Summary by Sourcery
Bug Fixes: