Skip to content

feat: add USE_PDFIUM_BUNDLE option to support external pdfium #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzwind merged 1 commit into from
Feb 5, 2026
+18 −2
Merged

feat: add USE_PDFIUM_BUNDLE option to support external pdfium #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ if(CMAKE_BUILD_TYPE STREQUAL "Release")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-z,relro -Wl,-z,now")
endif()

# Option to use bundled PDFium
option(USE_PDFIUM_BUNDLE ON)

# 设置C++标准
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
Expand Down Expand Up @@ -156,10 +159,13 @@ add_link_options(
)

# 添加子项目
add_subdirectory(3rdparty/deepin-pdfium)
add_subdirectory(reader)
add_subdirectory(htmltopdf)

if (USE_PDFIUM_BUNDLE)
add_subdirectory(3rdparty/deepin-pdfium)
endif()

# translation files
TRANSLATION_GENERATE(QM_FILES ${CMAKE_SOURCE_DIR}/translations)
add_custom_target(${PROJECT_NAME}_qm_files DEPENDS ${QM_FILES})
Expand Down
12 changes: 11 additions & 1 deletion reader/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ find_package(PkgConfig REQUIRED)
pkg_check_modules(LIBJPEG REQUIRED libjpeg)
pkg_check_modules(DDJVU REQUIRED ddjvuapi)

# Use pdfium in system default
if (NOT USE_PDFIUM_BUNDLE)
pkg_check_modules(Deepin-pdfium REQUIRED IMPORTED_TARGET deepin-pdfium)
endif()

if (XPS_SUPPORT_ENABLED)
pkg_check_modules(XPS_DEPS REQUIRED libgxps cairo glib-2.0 gobject-2.0 freetype2)
endif()
Expand Down Expand Up @@ -107,7 +112,6 @@ endif()
# 添加资源文件
set(READER_LINK_LIBS
${LINK_LIBS}
deepin-pdfium-reader
${LIBJPEG_LIBRARIES}
${DDJVU_LIBRARIES}
)
Expand Down Expand Up @@ -140,6 +144,12 @@ else()
)
endif()

if (USE_PDFIUM_BUNDLE)
target_link_libraries(deepin-reader PRIVATE deepin-pdfium-reader)
else()
target_link_libraries(deepin-reader PRIVATE PkgConfig::Deepin-pdfium)
endif()

target_sources(deepin-reader PRIVATE ${reader_RESOURCES})

# 安装目标
Expand Down