Remove backward compatibility for DHW time switch programs

Co-authored-by: liudger <4112111+liudger@users.noreply.github.com>

Author: Copilot

examples/control.py

@@ -225,9 +225,11 @@ async def main() -> None:
 
         # Example: Set DHW time program for Monday
         print("\nSetting DHW time program for Monday to 13:00-14:00")
-        await bsblan.set_hot_water(
-            dhw_time_program_monday="13:00-14:00 ##:##-##:## ##:##-##:##"
+        from bsblan.models import DHWTimeSwitchPrograms
+        dhw_programs = DHWTimeSwitchPrograms(
+            monday="13:00-14:00 ##:##-##:## ##:##-##:##"
         )
+        await bsblan.set_hot_water(dhw_time_programs=dhw_programs)
 
 
 if __name__ == "__main__":

src/bsblan/bsblan.py

@@ -567,7 +567,6 @@ async def set_hot_water(
         reduced_setpoint: float | None = None,
         operating_mode: str | None = None,
         dhw_time_programs: DHWTimeSwitchPrograms | None = None,
-        **kwargs: str | None,
     ) -> None:
         """Change the state of the hot water system through BSB-Lan.
 
@@ -576,22 +575,8 @@ async def set_hot_water(
             reduced_setpoint (float | None): The reduced setpoint temperature to set.
             operating_mode (str | None): The operating mode to set.
             dhw_time_programs (DHWTimeSwitchPrograms | None): Time switch programs.
-            **kwargs: Legacy parameters for backward compatibility including:
-                dhw_time_program_monday, dhw_time_program_tuesday, etc.
 
         """
-        # Handle backward compatibility through kwargs
-        if dhw_time_programs is None and kwargs:
-            dhw_time_programs = DHWTimeSwitchPrograms(
-                monday=kwargs.get("dhw_time_program_monday"),
-                tuesday=kwargs.get("dhw_time_program_tuesday"),
-                wednesday=kwargs.get("dhw_time_program_wednesday"),
-                thursday=kwargs.get("dhw_time_program_thursday"),
-                friday=kwargs.get("dhw_time_program_friday"),
-                saturday=kwargs.get("dhw_time_program_saturday"),
-                sunday=kwargs.get("dhw_time_program_sunday"),
-                standard_values=kwargs.get("dhw_time_program_standard_values"),
-            )
 
         # Validate only one parameter is being set
         time_program_params = []

tests/test_dhw_time_switch.py

@@ -23,9 +23,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     """
     # Test setting time program for Monday
     assert isinstance(mock_bsblan._request, AsyncMock)
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_monday="13:00-14:00 ##:##-##:## ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        monday="13:00-14:00 ##:##-##:## ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -36,9 +37,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Tuesday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_tuesday="06:00-08:00 17:00-20:00 ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        tuesday="06:00-08:00 17:00-20:00 ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -49,9 +51,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Wednesday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_wednesday="07:30-09:00 18:00-21:30 ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        wednesday="07:30-09:00 18:00-21:30 ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -62,9 +65,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Thursday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_thursday="06:00-09:00 16:00-22:00 ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        thursday="06:00-09:00 16:00-22:00 ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -75,9 +79,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Friday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_friday="06:00-09:00 15:00-23:00 ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        friday="06:00-09:00 15:00-23:00 ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -88,9 +93,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Saturday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_saturday="08:00-23:00 ##:##-##:## ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        saturday="08:00-23:00 ##:##-##:## ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -101,9 +107,10 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting time program for Sunday
-    await mock_bsblan.set_hot_water(
-        dhw_time_program_sunday="08:00-22:00 ##:##-##:## ##:##-##:##"
+    dhw_programs = DHWTimeSwitchPrograms(
+        sunday="08:00-22:00 ##:##-##:## ##:##-##:##"
     )
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -114,7 +121,8 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting standard values
-    await mock_bsblan.set_hot_water(dhw_time_program_standard_values="0")
+    dhw_programs = DHWTimeSwitchPrograms(standard_values="0")
+    await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
     mock_bsblan._request.assert_awaited_with(
         base_path="/JS",
         data={
@@ -125,11 +133,12 @@ async def test_set_dhw_time_program(mock_bsblan: BSBLAN) -> None:
     )
 
     # Test setting multiple parameters (should raise an error)
+    dhw_programs = DHWTimeSwitchPrograms(
+        monday="13:00-14:00 ##:##-##:## ##:##-##:##",
+        tuesday="06:00-08:00 17:00-20:00 ##:##-##:##",
+    )
     with pytest.raises(BSBLANError, match=MULTI_PARAMETER_ERROR_MSG):
-        await mock_bsblan.set_hot_water(
-            dhw_time_program_monday="13:00-14:00 ##:##-##:## ##:##-##:##",
-            dhw_time_program_tuesday="06:00-08:00 17:00-20:00 ##:##-##:##",
-        )
+        await mock_bsblan.set_hot_water(dhw_time_programs=dhw_programs)
 
 
 @pytest.mark.asyncio