[smart-log] feat: add rate limit retry logic#36
Closed
luqven wants to merge 1 commit intosmart-log/1-stack-apifrom
Closed
[smart-log] feat: add rate limit retry logic#36luqven wants to merge 1 commit intosmart-log/1-stack-apifrom
luqven wants to merge 1 commit intosmart-log/1-stack-apifrom
Conversation
Add automatic retry with exponential backoff for GitHub API rate limits. New functionality in src/api/mod.rs: - RateLimitError struct with reset time info and Display impl - parse_rate_limit_headers() to extract X-RateLimit-* headers - is_rate_limited() to detect 429 and 403 with rate limit headers - send_with_retry() for automatic retry with exponential backoff Retries up to 3 times with 1s, 2s, 4s delays before returning a RateLimitError with helpful message showing when to retry. Includes 6 new tests for retry logic.
This was referenced Dec 29, 2025
Owner
Author
|
Landed via #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic retry with exponential backoff for GitHub API rate limits (HTTP 429).
Changes
Modified:
src/api/mod.rsRateLimitErrorstruct with reset time info andDisplayimpl for user-friendly messagesparse_rate_limit_headers()- ExtractX-RateLimit-*headers from responseis_rate_limited()- Detect rate limiting (429 or 403 with rate limit headers)send_with_retry()- Automatic retry with exponential backoffBehavior
RateLimitErrorwith helpful message: "Try again in X minutes"Tests
6 new tests:
test_rate_limit_error_display_with_reset/without_resettest_send_with_retry_success_first_trytest_send_with_retry_rate_limit_then_successtest_send_with_retry_exhaustedtest_send_with_retry_403_with_rate_limitStacked PR Chain: smart-log