Similarities with nilnesserr

[ccoVeille]

Your linter reminds me

https://github.com/alingse/nilnesserr

@alingse

Aren't you both looking in the same direction?

I feel like it's a linter about the same idea.
I could be wrong.

[m-ocean-it]

Hi there! Looks similar. And come to think of it, maybe, my whole linter is, also, really just about not returning nil-errors... I have to contemplate that and, also, test nilnesserr against the same projects towards which I've been calibrating my linter. If that's the case, then I'll probably abandon the project. But, in theory, this linter is capable of detecting additional programmer mistakes when the returned error is not nil but still not the correct one.

[ccoVeille]

What would you think about it @alingse @ldez and @alexandear ?

I think nilnessner has a risk of false-positive which didn't make it a candidate for golangci-lint .

Maybe yours will have a narrow perimeter, and would be accepted.

I wasn't here to ask you to abandon. It's not my role and I'm not legitimate about it.

My ideas was somehow to make alingse and you discover each other project.

Maybe one linter would be enough, maybe one would find ideas and edge cases they didn't think about, and so add them to their respective linter.

Here is why I dropped a message

[ldez]

My POV is expressed inside golangci/golangci-lint#5875 (comment)

[m-ocean-it]

I wasn't here to ask you to abandon

No, of course! Don't worry, I'm here as long as I see a possibility of bringing value ;)

[m-ocean-it]

Applied both linters to a project at work. Quite an overlap!

Was pleasantly surprized that nilnesserr also detected mistakes with logging:

if getReviewsErr != nil {
	logger.ErrorKV(ctx, "...", "error", err) // <----- wrong error var
}

[m-ocean-it]

nilnesserr failed to detect this problem, while correcterr did (I guess, because there's no way to know for sure that err there would be nil):

newInsertedPhotos, err := db.InsertPhotosTx(ctx, tx, photosToInsert)
if err != nil {
	return nil, errors.Wrap(err, "insert photos failed")
}

/**/

for _, currentPhoto := range photosCurrentState {
	/**/

	if !isFound {
		/**/

		updPhotoStatusQuery, errU := db.prepareUpdatePhotoStatusQuery(photoEntityFilter, review_admin.PhotoStatusDeletedByClient)
		if errU != nil {
			return nil, errU
		}
		if _, err = tx.Execx(
			wrapCtxWithName(ctx, "update_photo_status"),
			updPhotoStatusQuery,
		); err != nil {
			return nil, errors.Wrap(err, "update photo failed")
		}

		/**/
	}

	/**/
}

/**/

errUpdateItemMeta := db.UpsertPublishedMediaCount(ctx, tx, &UpsertMediaCountSpec{/**/})
if errUpdateItemMeta != nil {
	return nil, fmt.Errorf("db.upsertPublishedMediaCount: %w", err) // <-------------------------- wrong!
}