Skip to content

Fix space_after for array #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charsbar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix space_after for array #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46afe3e
Add space(s) after commas in an array as well
charsbar Jan 4, 2026
23f714a
Add a test
charsbar Jan 4, 2026
f26a188
Only add spaces if nothing else will be added
charsbar Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/JSON/PP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,8 @@ sub allow_bigint {
$self->_down_indent() if ($self->{PROPS}[P_INDENT]);

return '[]' unless @res;
return '[' . $pre . join( ",$pre", @res ) . $post . ']';
my $space = $pre eq '' && $self->{PROPS}[P_SPACE_AFTER] ? ' ' : '';
return '[' . $pre . join( ",$space$pre", @res ) . $post . ']';
}

sub _looks_like_number {
Expand Down
15 changes: 15 additions & 0 deletions t/gh_89_space_after_comma.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
use strict;
use warnings;
use Test::More;

BEGIN { $ENV{PERL_JSON_BACKEND} = 0; }

my @candidates = qw(JSON::PP JSON::XS Cpanel::JSON::XS);

for my $json_module (@candidates) {
eval "require $json_module; 1" or next;
my $got = $json_module->new->utf8->space_after(1)->encode({x=>[1,2]});
is $got => qq!{"x": [1, 2]}!, "$json_module has a space after 1";
}

done_testing;
Loading