You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groups multiple attempts/ascents of the same climb on the same day into
a single card showing a summary (e.g., "3 attempts" or "Sent, 2 attempts").
The thumbnail still navigates to the climb info page when clicked.
Groups multiple attempts/ascents of the same climb on the same day into
a single card showing a summary (e.g., "3 attempts" or "Sent, 2 attempts").
The thumbnail still navigates to the climb info page when clicked.
…feed
- Add new GraphQL type GroupedAscentFeedItem and query userGroupedAscentsFeed
- Backend groups attempts by climbUuid + date with counts for flash/send/attempt
- Track best quality rating and latest comment per group
- Frontend displays grouped entries with combined status summary
- Thumbnail click navigates to climb info page (existing behavior)
Examples of grouped display:
- "3 attempts" - multiple failed attempts
- "6 sends" - multiple successful sends
- "Flashed, 2 attempts" - one flash with additional attempts
- "3 sends, 3 attempts" - mixed results
⚠️Needs attention - Critical performance issue: fetching all user ticks without limit before pagination.
Issues
Performance: Fetches all rows before pagination - packages/backend/src/graphql/resolvers/ticks/queries.ts:228-255 - The query fetches ALL ticks for a user (no LIMIT), loads them into memory, groups them, then paginates. For users with thousands of logged climbs, this will cause memory issues and slow response times. Consider SQL-level grouping/pagination or at minimum add a reasonable fetch limit.
Missing test coverage - No tests for the new userGroupedAscentsFeed query. Given the complex grouping logic, edge cases should be tested (empty results, single item groups, multiple statuses on same day/climb).
Unused import - packages/web/app/components/activity-feed/ascents-feed.tsx:10 - Title is imported but no longer used after refactoring.
⚠️Needs attention - Missing tests for new query, potential performance issue with in-memory grouping.
Issues
No tests for userGroupedAscentsFeed resolver (packages/backend/src/graphql/resolvers/ticks/queries.ts:213-362) - The codebase has existing resolver tests in packages/backend/src/__tests__/graphql-resolvers.test.ts, but this new query lacks test coverage for grouping logic, edge cases (empty results, single items, pagination bounds), and error handling.
In-memory grouping may cause performance issues (packages/backend/src/graphql/resolvers/ticks/queries.ts:254-336) - Fetches up to 500 records then groups in memory. For users with many climbs, this loads unnecessary data when only the first page is needed. Consider SQL-level grouping or a more efficient pagination strategy.
Unused import (packages/web/app/components/activity-feed/ascents-feed.tsx:27) - Title is destructured from Typography but never used after refactoring.
Missing userId validation (packages/backend/src/graphql/resolvers/ticks/queries.ts:217) - Unlike other queries that validate boardType, userId is used directly without validation. Consider validating the format to prevent potential issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups multiple attempts/ascents of the same climb on the same day into
a single card showing a summary (e.g., "3 attempts" or "Sent, 2 attempts").
The thumbnail still navigates to the climb info page when clicked.