Do not call JSON.stringify() for circular structures

[binarykitchen]

This library is throwing a new error we haven't seen before:

TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Socket'
| property '_httpMessage' -> object with constructor 'ClientRequest'
--- property 'socket' closes the circle
at JSON.stringify ()
at /var/www/videomail/production/source/node_modules/errormailer/index.js:107:57

It's this code line

locals.errorProperties[property] = JSON.stringify(errorToBeSent[property])

Let's fix this in a small PR by not calling JSON.stringify and consider another more robust npm package.

Maybe fast-safe-stringify or does anyone have a better idea?

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[binarykitchen]

Yeah, I'll try to cover with unit tests ...

(Minor question: how do you extract circular JSON's these days?)

[mcollina]

We can use util.inspect() instead. There is no need to use JSON here.

[binarykitchen]

Aye. I'll take care of it tomorrow. Bedtime in NZ now ...