set_socket_non_blocking() is commented out in udpstream.c

[wilsonNg007]

In udpstream.c, the set_socket_non_blocking() call is commented out. Any reason why?

I thought non-blocking I/O is the only default I/O model implemented ntttcp-for-linux, and it is better for Tput performance (than blocking I/O). The tcp mode is still setting non-blocking socket mode.

Can we uncomment it?

[wilsonNg007]

@glima , do you know why?

[glima]

@simonxiaoss seems to the one last editing those bits (and to be honest I barely know this code base)

[wilsonNg007]

Thanks @glima. I also noticed from "Add support for UDP in IPv4" PR (June 25,2016) which added the udpstream source files, that set_socket_non_blocking code was already commented out from the beginning. It's never been enabled.

@simonxiaoss, is there any concern if non_blocking socket mode is enabled for UDP ?

[simonxiaoss]

To be frankly, the UDP processing is not completely implemented and not well tested. This initial version is just a simple duplication of the TCP stream with blocking mode.

Yes, we should set the UDP socket as "O_NONBLOCK", and also handle it properly when we receive the data.

We should combine the code and use a unified way to process TCP/UDP too.

[wilsonNg007]

Hi @santoshx ,

I recalled you have worked on this trying to enable nonblocking mode for UDP socket, but you encountered some issue. Do you have any update? Thanks.