From d29f3d17c24f7dabe6a8439bd170f7096ac6ce8d Mon Sep 17 00:00:00 2001 From: Daniel Keywan Hollister Date: Thu, 13 Mar 2025 05:24:56 -0700 Subject: [PATCH 1/2] Add TSNE param `max_iter` and deprecate `n_iter` in scikit-learn sklearn.manifold._t_sne.TSNE has added `max_iter` to replace `n_iter`, which has been deprecated since v1.5 --- stubs/sklearn/manifold/_t_sne.pyi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/stubs/sklearn/manifold/_t_sne.pyi b/stubs/sklearn/manifold/_t_sne.pyi index bf21b357..b73e3b2d 100644 --- a/stubs/sklearn/manifold/_t_sne.pyi +++ b/stubs/sklearn/manifold/_t_sne.pyi @@ -40,7 +40,8 @@ def trustworthiness( ) -> float: ... class TSNE(BaseEstimator): - n_iter_: int = ... + max_iter: None | int = ... + n_iter_: str | int = ... learning_rate_: float = ... feature_names_in_: ndarray = ... n_features_in_: int = ... @@ -62,7 +63,7 @@ class TSNE(BaseEstimator): perplexity: Float = 30.0, early_exaggeration: Float = 12.0, learning_rate: float | Literal["auto"] = "auto", - n_iter: Int = 1000, + max_iter: None | Int = None n_iter_without_progress: Int = 300, min_grad_norm: Float = 1e-7, metric: str | Callable = "euclidean", @@ -74,6 +75,7 @@ class TSNE(BaseEstimator): angle: Float = 0.5, n_jobs: None | Int = None, square_distances: str | bool = "deprecated", + n_iter: str | Int = "deprecated", ) -> None: ... def fit_transform(self, X: MatrixLike, y: None | ndarray = None) -> ndarray: ... def fit(self, X: MatrixLike, y=None) -> ndarray: ... From 0f5c7115efcce19083645b8f4ce44eb4e421d68c Mon Sep 17 00:00:00 2001 From: Erik De Bonte Date: Thu, 13 Mar 2025 18:06:14 -0700 Subject: [PATCH 2/2] Add missing comma --- stubs/sklearn/manifold/_t_sne.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/sklearn/manifold/_t_sne.pyi b/stubs/sklearn/manifold/_t_sne.pyi index b73e3b2d..89b5f858 100644 --- a/stubs/sklearn/manifold/_t_sne.pyi +++ b/stubs/sklearn/manifold/_t_sne.pyi @@ -63,7 +63,7 @@ class TSNE(BaseEstimator): perplexity: Float = 30.0, early_exaggeration: Float = 12.0, learning_rate: float | Literal["auto"] = "auto", - max_iter: None | Int = None + max_iter: None | Int = None, n_iter_without_progress: Int = 300, min_grad_norm: Float = 1e-7, metric: str | Callable = "euclidean",