pr feedback

Author: bmiddha

apps/zipsync/package.json

@@ -18,7 +18,6 @@
     "_phase:test": "heft run --only test -- --clean"
   },
   "dependencies": {
-    "@rushstack/node-core-library": "workspace:*",
     "@rushstack/terminal": "workspace:*",
     "@rushstack/ts-command-line": "workspace:*",
     "typescript": "~5.8.2",

apps/zipsync/src/ZipSyncCommandLineParser.ts

@@ -9,7 +9,6 @@ import type {
   IRequiredCommandLineStringListParameter,
   CommandLineChoiceParameter
 } from '@rushstack/ts-command-line/lib/index';
-import { InternalError } from '@rushstack/node-core-library/lib/InternalError';
 import type { ConsoleTerminalProvider } from '@rushstack/terminal/lib/ConsoleTerminalProvider';
 import type { ITerminal } from '@rushstack/terminal/lib/ITerminal';
 
@@ -92,7 +91,8 @@ export class ZipSyncCommandLineParser extends CommandLineParser {
 
   protected override async onExecuteAsync(): Promise<void> {
     if (this._debugParameter.value) {
-      InternalError.breakInDebugger = true;
+      // eslint-disable-next-line no-debugger
+      debugger;
       this._terminalProvider.debugEnabled = true;
       this._terminalProvider.verboseEnabled = true;
     }

apps/zipsync/src/benchmark.test.ts

@@ -222,7 +222,8 @@ function benchZipSyncScenario(
   });
 }
 
-describe(`archive benchmarks (iterations=${ITERATIONS})`, () => {
+// the benchmarks are skipped by default because they require external tools (tar, zip) to be installed
+describe.skip(`archive benchmarks (iterations=${ITERATIONS})`, () => {
   it('tar', () => {
     if (!isTarAvailable()) {
       console.log('Skipping tar test because tar is not available');
@@ -467,7 +468,7 @@ afterAll(() => {
   const resultText = outputLines.join('\n');
   console.log(resultText);
   try {
-    const resultFile = path.join(__dirname, '..', 'temp', `benchmark-results-${runId}.txt`);
+    const resultFile = path.join(__dirname, '..', 'temp', `benchmark-results.txt`);
     fs.writeFileSync(resultFile, resultText, { encoding: 'utf-8' });
     console.log(`Benchmark results written to: ${resultFile}`);
   } catch (e) {

apps/zipsync/src/hash.ts

@@ -0,0 +1,42 @@
+// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
+// See LICENSE in the project root for license information.
+
+import { closeSync, readSync, fstatSync, type Stats } from 'node:fs';
+import { createHash, type Hash } from 'node:crypto';
+
+const buffer: Buffer = Buffer.allocUnsafeSlow(1 << 24);
+
+export function computeFileHash(fd: number): string | false {
+  try {
+    const hash: Hash = createHash('sha256');
+    let totalBytesRead: number = 0;
+    let bytesRead: number;
+    do {
+      bytesRead = readSync(fd, buffer, 0, buffer.length, -1);
+      if (bytesRead <= 0) {
+        break;
+      }
+      totalBytesRead += bytesRead;
+      hash.update(buffer.subarray(0, bytesRead));
+    } while (bytesRead > 0);
+    if (totalBytesRead === 0) {
+      // Sometimes directories get treated as empty files
+      const stat: Stats = fstatSync(fd);
+      if (!stat.isFile()) {
+        return false;
+      }
+    }
+
+    return hash.digest('hex');
+  } catch (err) {
+    // There is a bug in node-core-library where it doesn't handle if the operation was on a file descriptor
+    if (err.code === 'EISDIR' || err.code === 'ENOENT' || err.code === 'ENOTDIR') {
+      return false;
+    }
+    throw err;
+  } finally {
+    if (fd !== undefined) {
+      closeSync(fd);
+    }
+  }
+}