Fix maxRequests "pause" button (#2579)

* Fix maxRequests "pause" button
Fix #283220

* Fix test

Author: roblourens

src/extension/prompt/common/specialRequestTypes.ts

@@ -13,10 +13,11 @@ export interface IToolCallIterationIncrease {
 const isToolCallIterationIncrease = (c: unknown): c is IToolCallIterationIncrease => !!(c && typeof (c as IToolCallIterationIncrease).copilotRequestedRoundLimit === 'number');
 
 export const getRequestedToolCallIterationLimit = (request: ChatRequest) => request.acceptedConfirmationData?.find(isToolCallIterationIncrease)?.copilotRequestedRoundLimit;
+export const getRejectedToolCallIterationLimit = (request: ChatRequest) => request.rejectedConfirmationData?.find(isToolCallIterationIncrease)?.copilotRequestedRoundLimit;
 
 // todo@connor4312 improve with the choices API
 export const cancelText = () => l10n.t('Pause');
-export const isToolCallLimitCancellation = (request: ChatRequest) => !!getRequestedToolCallIterationLimit(request) && request.prompt.includes(cancelText());
+export const isToolCallLimitCancellation = (request: ChatRequest) => !!getRejectedToolCallIterationLimit(request);
 export const isToolCallLimitAcceptance = (request: ChatRequest) => !!getRequestedToolCallIterationLimit(request) && !isToolCallLimitCancellation(request);
 export interface IContinueOnErrorConfirmation {
 	copilotContinueOnError: true;

src/extension/prompt/node/test/defaultIntentRequestHandler.spec.ts

@@ -25,7 +25,7 @@ import { isObject, isUndefinedOrNull } from '../../../../util/vs/base/common/typ
 import { generateUuid } from '../../../../util/vs/base/common/uuid';
 import { SyncDescriptor } from '../../../../util/vs/platform/instantiation/common/descriptors';
 import { IInstantiationService } from '../../../../util/vs/platform/instantiation/common/instantiation';
-import { ChatLocation, ChatResponseConfirmationPart, LanguageModelTextPart, LanguageModelToolResult } from '../../../../vscodeTypes';
+import { ChatLocation, ChatResponseConfirmationPart, ChatResponseMarkdownPart, LanguageModelTextPart, LanguageModelToolResult } from '../../../../vscodeTypes';
 import { ToolCallingLoop } from '../../../intents/node/toolCallingLoop';
 import { ToolResultMetadata } from '../../../prompts/node/panel/toolCalling';
 import { createExtensionUnitTestingServices } from '../../../test/node/services';
@@ -329,16 +329,14 @@ suite('defaultIntentRequestHandler', () => {
 		expect(last).toBeInstanceOf(ChatResponseConfirmationPart);
 
 		const request = new TestChatRequest();
-		request.acceptedConfirmationData = [(last as ChatResponseConfirmationPart).data];
+		request.rejectedConfirmationData = [(last as ChatResponseConfirmationPart).data];
 		request.prompt = (last as ChatResponseConfirmationPart).buttons![1];
 		const handler2 = makeHandler({ request });
 		await handler2.getResult();
 
-		expect(response.at(-1)).toMatchInlineSnapshot(`
-			ChatResponseMarkdownPart {
-			  "value": MarkdownString {},
-			}
-		`);
+		const last2 = response.at(-1);
+		expect(last2).toBeInstanceOf(ChatResponseMarkdownPart);
+		expect((last2 as ChatResponseMarkdownPart).value.value).toMatchInlineSnapshot(`"Let me know if there's anything else I can help with!"`);
 	});
 });