Helm chart improvement for private registry imagePullSecrets

[antoinetran]

Is your feature request related to a problem? Please describe.
1/ It is not possible to configure imagePullSecrets for sidecar, it does not uses the configuration set in values.yaml.
2/ It is not possible to rewrite the prefix of sidecar image, contrary to all other image in minio operator and tenant.

Describe the solution you'd like
1/ imagePullSecrets field in values should be read by minio when creating sidecar.
2/ Like other image configuration in minio:

  image:
    repository: quay.io/minio/operator
    tag: v7.1.1
    pullPolicy: IfNotPresent

the sidecar default configuration in values.yaml should be

  sidecar:
    image:
      repository: quay.io/minio/operator
      tag: v7.1.1
      pullPolicy: IfNotPresent

instead of just sidecar: {}
This let us rewrite the repository to inject private reposistory and only that. We don't want to rewrite the tag for example.

Describe alternatives you've considered

Additional context

[ramondeklein]

Changing just the Helm image is not enough, because it also requires changes to the Tenant CRD as well. We do have a commercial offering (AIStor) with support for OpenShift, custom repositories, ... If you can't move to AIStor, then use a private repository that doesn't require any pull secrets instead.

[antoinetran]

then use a private repository that doesn't require any pull secrets instead.

Hi @ramondeklein , the current code of values.yaml already implement partially the notion of imagePullSecrets, whether in operator or in tenant. See https://github.com/minio/operator/blob/v7.1.1/helm/operator/values.yaml#L82 and https://github.com/minio/operator/blob/v7.1.1/helm/tenant/values.yaml#L39

So this is rather a bug because the already implemented feature does not work.

I understand the business move to restrict lots of feature from the opensource component but not that we do not fix the issue. Also a private repository without password is a no go!! Can you reopen the issue please?

[ramondeklein]

The image pull secrets only apply to the operator image itself.