Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Lack of development value breaks production #76

@bpinto

Description

@bpinto

When using webpack to generate assets server side, e.g. PDF, the dev_server.host is not set. Is there a reason why the host calculation below is not inside the dev_server.enabled check?

host = ::Rails.configuration.webpack.dev_server.host
host = instance_eval(&host) if host.respond_to?(:call)

if ::Rails.configuration.webpack.dev_server.enabled
  paths.map! do |p|
    "#{protocol}://#{host}:#{port}#{p}"
  end
end

paths

Ref: https://github.com/mipearson/webpack-rails/blob/master/lib/webpack/rails/helper.rb#L24-L33

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions