From 7cf326efcc0317f783b4f8dfe60e50481855e5b6 Mon Sep 17 00:00:00 2001
From: Shay Goldstein <shay_goldstein@mckinsey.com>
Date: Wed, 18 Feb 2026 15:22:44 +0200
Subject: [PATCH] [Kafka] Update external access to kafka

Update external service configuration to use NodePort for external access
[CEML-651](https://iguazio.atlassian.net/browse/CEML-651)
---
 .github/workflows/ci.yaml   | 44 ++++++++++++++++++++++++++++++++++++-
 charts/mlrun-ce/Chart.yaml  |  2 +-
 charts/mlrun-ce/values.yaml | 11 ++++++++--
 3 files changed, 53 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index e1704bdd..2a1b2c1b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -35,9 +35,51 @@ jobs:
           if [[ -n "$changed" ]]; then
             echo "changed=true" >> "$GITHUB_OUTPUT"
           fi
+      - name: Check version bump (handles rcN numerically)
+        if: steps.list-changed.outputs.changed == 'true'
+        run: |
+          TARGET_BRANCH=${{ github.event.repository.default_branch }}
+          OLD_VERSION=$(git show origin/$TARGET_BRANCH:charts/mlrun-ce/Chart.yaml | grep '^version:' | awk '{print $2}')
+          NEW_VERSION=$(grep '^version:' charts/mlrun-ce/Chart.yaml | awk '{print $2}')
+          echo "Old version: $OLD_VERSION"
+          echo "New version: $NEW_VERSION"
+          
+          # Extract base version (before hyphen) and prerelease (after hyphen)
+          OLD_BASE=$(echo "$OLD_VERSION" | cut -d'-' -f1)
+          NEW_BASE=$(echo "$NEW_VERSION" | cut -d'-' -f1)
+          OLD_PRE=$(echo "$OLD_VERSION" | cut -d'-' -f2-)
+          NEW_PRE=$(echo "$NEW_VERSION" | cut -d'-' -f2-)
+          
+          # If base version increased, that's a valid bump
+          if [[ "$NEW_BASE" > "$OLD_BASE" ]]; then
+            echo "✓ Base version bumped: $OLD_BASE -> $NEW_BASE"
+            exit 0
+          fi
+          
+          # If releasing (removing prerelease), that's valid
+          if [[ "$NEW_VERSION" == "$NEW_BASE" && "$OLD_VERSION" != "$OLD_BASE" ]]; then
+            echo "✓ Released: $OLD_VERSION -> $NEW_VERSION"
+            exit 0
+          fi
+          
+          # Extract numeric part from prerelease (rc9 -> 9, rc10 -> 10)
+          OLD_NUM=$(echo "$OLD_PRE" | sed 's/[^0-9]//g')
+          NEW_NUM=$(echo "$NEW_PRE" | sed 's/[^0-9]//g')
+          
+          # Compare prerelease numbers numerically
+          if [[ -n "$NEW_NUM" && -n "$OLD_NUM" && "$NEW_NUM" -gt "$OLD_NUM" ]]; then
+            echo "✓ Prerelease bumped: $OLD_PRE -> $NEW_PRE"
+            exit 0
+          fi
+          
+          echo "✖ Version not bumped! $OLD_VERSION -> $NEW_VERSION"
+          exit 1
+          
       - name: Run chart-testing (lint)
-        run: make helm-lint
         if: steps.list-changed.outputs.changed == 'true'
+        run: |
+          helm lint charts/mlrun-ce
+          ct lint --target-branch ${{ github.event.repository.default_branch }} --check-version-increment=false
         env:
           HELM_LINT_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
 
diff --git a/charts/mlrun-ce/Chart.yaml b/charts/mlrun-ce/Chart.yaml
index 92bc7cb0..33fb6d16 100644
--- a/charts/mlrun-ce/Chart.yaml
+++ b/charts/mlrun-ce/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v1
 name: mlrun-ce
-version: 0.11.0-rc9
+version: 0.11.0-rc10
 description: MLRun Open Source Stack
 home: https://iguazio.com
 icon: https://www.iguazio.com/wp-content/uploads/2019/10/Iguazio-Logo.png
diff --git a/charts/mlrun-ce/values.yaml b/charts/mlrun-ce/values.yaml
index bed3e5b0..42b86d3e 100644
--- a/charts/mlrun-ce/values.yaml
+++ b/charts/mlrun-ce/values.yaml
@@ -606,10 +606,17 @@ kafka:
       port: 9093
       type: internal
       tls: false
-    - name: internal
+    - name: external
       port: 9094
-      type: internal
+      type: nodeport
       tls: false
+      configuration:
+        bootstrap:
+          nodePort: 30094
+        # For external access, set advertisedHost per broker:
+        # brokers:
+        #   - broker: 0
+        #     advertisedHost: kafka.<namespace>.<system>.lab.iguazeng.com
 
   storage:
     type: persistent-claim