From 49431994301ebe0c055841f43f7895fd2c9f7c88 Mon Sep 17 00:00:00 2001 From: Kilian B <60846047+knowbased@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:03:30 +0100 Subject: [PATCH 1/2] fix: block doesnt handle when diff is same but file not --- .../GitModelImporter.class.st | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st b/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st index 165980f..f316188 100644 --- a/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st +++ b/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st @@ -145,9 +145,15 @@ GitModelImporter >> blockForBranchEquality [ { #category : #equality } GitModelImporter >> blockForDiffEquality [ - ^ [ :existing :new | - existing diffString size = new diffString size and: [ - existing diffString = new diffString ] ] + +^ [ :existing :new | + | sameSize sameDiff sameFile | + sameSize := existing diffString size = new diffString size. + sameDiff := existing diffString = new diffString. + sameFile := existing new_path = new new_path. + + sameSize and: (sameDiff and: sameFile). + ] ] { #category : #equality } From 52bd33ffcd1657198f57b8f58fca2362241c73c9 Mon Sep 17 00:00:00 2001 From: Kilian B <60846047+knowbased@users.noreply.github.com> Date: Thu, 13 Nov 2025 09:13:21 +0100 Subject: [PATCH 2/2] Refactor: replace parentheses with brackets Co-authored-by: Benoit Verhaeghe --- src/GitProjectHealth-Model-Importer/GitModelImporter.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st b/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st index f316188..b8bb81d 100644 --- a/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st +++ b/src/GitProjectHealth-Model-Importer/GitModelImporter.class.st @@ -152,7 +152,7 @@ GitModelImporter >> blockForDiffEquality [ sameDiff := existing diffString = new diffString. sameFile := existing new_path = new new_path. - sameSize and: (sameDiff and: sameFile). + sameSize and: [ sameDiff and: [ sameFile ] ]. ] ]