Skip to content
This repository was archived by the owner on Oct 3, 2018. It is now read-only.
This repository was archived by the owner on Oct 3, 2018. It is now read-only.

Add a test that opens and closes browser windows (as opposed to tabs) #125

@staktrace

Description

@staktrace

We had a leak recently (bug 1264161) where every time a browser window was opened and closed it would leak a bunch of stuff. Surprisingly (to me) none of our automation tests for this, since leak checking is done at shutdown which was too late for this particular scenario. AWSY however would have caught this sort of a leak if it opened and closed windows in addition to tabs. Something to consider adding, and I imagine it shouldn't be too hard. It could be as simple as an extra phase at the end of the test (after "After TP5, tabs closed [+30s, forced GC]") where we cycle through the TP5 set opening and closing each page in a new window, then do a force GC and grab another snapshot. I strongly suspect that such a test would have showed the leak.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions