Skip to content

Review Disabled Temperature Source Select #44

@samphonic

Description

@samphonic

Currently (after #42), the temperature source select menu is disabled by skipping registering it in Python because not creating it at all causes a lot of null pointer references in the code. However, this leaves the temperature source select component in a weird state and e.g. publishing fails (and it doesn't contain "Internal" even though it should still technically contain it.

We should review the code and potentially consider adding if (temperature_source_select_) {... guards around several blocks of code to protect the runtime from any configuration errors that cause temperature_source_select_ to be missing.

I think this is unique to temperature_source_select_, since we're not dynamically disabling any other components at this point, but might also be worth keeping an eye on when we do auto config (#13)

Metadata

Metadata

Assignees

No one assigned

    Labels

    low priorityUnlikely to change existing or new functionality; mostly for reviewing or optimizing code.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions