Add ruff lint rules for builtins, pathlib, and print detection

- Add A (builtins shadowing), PTH (pathlib), T20 (print) rules
- Fix: use Path.open() instead of open() in main.py
- Fix: rename vars to tpl_vars to avoid shadowing builtin
- Ignore T201 (print) in test files

Author: jensens

pyproject.toml

@@ -95,15 +95,18 @@ exclude = ["src/mxmake/_version.py"]
 
 [tool.ruff.lint]
 select = [
+    "A",    # flake8-builtins (shadowing builtins)
+    "B",    # flake8-bugbear
+    "C4",   # flake8-comprehensions
     "E",    # pycodestyle errors
     "F",    # pyflakes
-    "W",    # pycodestyle warnings
-    "B",    # flake8-bugbear
     "I",    # isort
-    "UP",   # pyupgrade
-    "C4",   # flake8-comprehensions
-    "SIM",  # flake8-simplify
+    "PTH",  # flake8-use-pathlib
     "RUF",  # ruff-specific
+    "SIM",  # flake8-simplify
+    "T20",  # flake8-print
+    "UP",   # pyupgrade
+    "W",    # pycodestyle warnings
 ]
 
 [tool.ruff.lint.isort]
@@ -118,4 +121,4 @@ order-by-type = false
 max-line-length = 120  # E501 triggers above this, allows flexibility
 
 [tool.ruff.lint.per-file-ignores]
-"src/mxmake/tests/*" = ["E101", "RUF012"]
+"src/mxmake/tests/*" = ["E101", "RUF012", "T201"]

src/mxmake/main.py

@@ -308,7 +308,7 @@ def init_command(args: argparse.Namespace):
     preseeds = None
     if args.preseeds:
         prompt = False
-        with open(args.preseeds) as fd:
+        with Path(args.preseeds).open() as fd:
             preseeds = yaml.load(fd.read(), yaml.SafeLoader)
 
     # Handle project-path-python from CLI or auto-detection

src/mxmake/templates.py

@@ -536,15 +536,15 @@ def target_folder(self) -> Path:
     @property
     def template_variables(self):
         site = {}
-        vars = {"site": site}
+        tpl_vars = {"site": site}
         site.setdefault("site_id", "Plone")
         site.setdefault("title", "Plone Site")
         site.setdefault("setup_content", False)
         site.setdefault("default_language", "en")
         site.setdefault("portal_timezone", "UTC")
         site.update(**self.settings)
         if "distribution" in site:
-            vars["distribution"] = site.pop("distribution")
+            tpl_vars["distribution"] = site.pop("distribution")
 
         # handle extension ids
         if site.get("extension_ids") is not None:
@@ -553,7 +553,7 @@ def template_variables(self):
             ]
         else:
             site["extension_ids"] = []
-        return vars
+        return tpl_vars
 
 
 ##############################################################################