From 3151c23bbbe8bf0ae74dae031e34b915bec1b53a Mon Sep 17 00:00:00 2001 From: Afshin Arani Date: Thu, 13 May 2021 21:11:58 +0430 Subject: [PATCH] Tests: load NumberToSendMessage in init process 738a849 moves loading of "NumberToSendMessage" property to SendMessage test even though there are 3 other tests that use that variable thereby breaking all 3 tests because of NumberToSendMessage being null. This commit moves the load process back to init phase so all 4 tests can use NumberToSendMessage. --- src/TgSharp.Tests/TgSharpTests.cs | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/TgSharp.Tests/TgSharpTests.cs b/src/TgSharp.Tests/TgSharpTests.cs index 2212cdeb..2d719624 100644 --- a/src/TgSharp.Tests/TgSharpTests.cs +++ b/src/TgSharp.Tests/TgSharpTests.cs @@ -118,6 +118,16 @@ private void GatherTestConfiguration() NumberToAddToChat = ConfigurationManager.AppSettings[nameof(NumberToAddToChat)]; if (string.IsNullOrEmpty(NumberToAddToChat)) Debug.WriteLine(appConfigMsgWarning, nameof(NumberToAddToChat)); + + NumberToSendMessage = ConfigurationManager.AppSettings[nameof(NumberToSendMessage)]; + if (string.IsNullOrWhiteSpace(NumberToSendMessage)) + Debug.WriteLine(appConfigMsgWarning, nameof(NumberToSendMessage)); + else + NumberToSendMessage = + NumberToSendMessage.StartsWith("+") ? + NumberToSendMessage.Substring(1, NumberToSendMessage.Length - 1) : + NumberToSendMessage; + } public virtual async Task AuthUser() @@ -150,15 +160,6 @@ public virtual async Task AuthUser() public virtual async Task SendMessageTest() { - NumberToSendMessage = ConfigurationManager.AppSettings[nameof(NumberToSendMessage)]; - if (string.IsNullOrWhiteSpace(NumberToSendMessage)) - throw new Exception($"Please fill the '{nameof(NumberToSendMessage)}' setting in app.config file first"); - - // this is because the contacts in the address come without the "+" prefix - var normalizedNumber = NumberToSendMessage.StartsWith("+") ? - NumberToSendMessage.Substring(1, NumberToSendMessage.Length - 1) : - NumberToSendMessage; - var client = NewClient(); await client.ConnectAsync(); @@ -167,7 +168,7 @@ public virtual async Task SendMessageTest() var user = result.Users .OfType() - .FirstOrDefault(x => x.Phone == normalizedNumber); + .FirstOrDefault(x => x.Phone == NumberToSendMessage); if (user == null) {