From d24e735cc2819755a7be41782850007e9ce3d5df Mon Sep 17 00:00:00 2001 From: Riedler Date: Mon, 16 Dec 2024 20:44:04 +0100 Subject: [PATCH 1/3] fix: allow null for vintage in get_all_users --- lbplanner/services/user/get_all_users.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lbplanner/services/user/get_all_users.php b/lbplanner/services/user/get_all_users.php index 442da81f..5235f75f 100644 --- a/lbplanner/services/user/get_all_users.php +++ b/lbplanner/services/user/get_all_users.php @@ -42,7 +42,7 @@ class user_get_all_users extends external_api { */ public static function get_all_users_parameters(): external_function_parameters { return new external_function_parameters([ - 'vintage' => new external_value(PARAM_TEXT, 'The vintage to filter the users by', VALUE_DEFAULT, null), + 'vintage' => new external_value(PARAM_TEXT, 'The vintage to filter the users by', VALUE_DEFAULT, null, NULL_ALLOWED), ]); } From c1a744f4d0463ff4dd9a8a528222159dc9fba365 Mon Sep 17 00:00:00 2001 From: Riedler Date: Tue, 17 Dec 2024 17:04:27 +0100 Subject: [PATCH 2/3] fixed: type in get_all_users function --- lbplanner/services/user/get_all_users.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lbplanner/services/user/get_all_users.php b/lbplanner/services/user/get_all_users.php index 5235f75f..5df4bc2a 100644 --- a/lbplanner/services/user/get_all_users.php +++ b/lbplanner/services/user/get_all_users.php @@ -53,7 +53,7 @@ public static function get_all_users_parameters(): external_function_parameters * @throws dml_exception * @throws invalid_parameter_exception */ - public static function get_all_users(string $vintage): array { + public static function get_all_users(?string $vintage): array { global $DB, $USER; self::validate_parameters(self::get_all_users_parameters(), ['vintage' => $vintage]); From efdf67a94ab2d66013f559c8b91e5f5f131e5fa0 Mon Sep 17 00:00:00 2001 From: Riedler Date: Tue, 17 Dec 2024 17:07:11 +0100 Subject: [PATCH 3/3] fix: type in docstring of get_all_users --- lbplanner/services/user/get_all_users.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lbplanner/services/user/get_all_users.php b/lbplanner/services/user/get_all_users.php index 5df4bc2a..c5de61b4 100644 --- a/lbplanner/services/user/get_all_users.php +++ b/lbplanner/services/user/get_all_users.php @@ -48,7 +48,7 @@ public static function get_all_users_parameters(): external_function_parameters /** * Gives back all users registered by the lbplanner app. - * @param string $vintage (optional) gives back all users with the given vintage + * @param ?string $vintage (optional) gives back all users with the given vintage * @throws moodle_exception * @throws dml_exception * @throws invalid_parameter_exception