From d0c1e66adb80b58670feda6d2df6cd4230424bac Mon Sep 17 00:00:00 2001 From: Riedler Date: Mon, 20 Jan 2025 11:04:04 +0100 Subject: [PATCH 1/2] fix: remove $lang from remaining user API --- lbplanner/services/user/update_user.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lbplanner/services/user/update_user.php b/lbplanner/services/user/update_user.php index 541b47c6..f0f785e8 100644 --- a/lbplanner/services/user/update_user.php +++ b/lbplanner/services/user/update_user.php @@ -39,7 +39,6 @@ class user_update_user extends external_api { */ public static function update_user_parameters(): external_function_parameters { return new external_function_parameters([ - 'lang' => new external_value(PARAM_TEXT, 'The language the user has selected', VALUE_DEFAULT, null), 'theme' => new external_value(PARAM_TEXT, 'The theme the user has selected', VALUE_DEFAULT, null), 'colorblindness' => new external_value( PARAM_TEXT, @@ -65,13 +64,12 @@ public static function update_user_parameters(): external_function_parameters { * @throws dml_exception * @throws invalid_parameter_exception */ - public static function update_user($lang, $theme, $colorblindness, $displaytaskcount): array { + public static function update_user($theme, $colorblindness, $displaytaskcount): array { global $DB, $USER; self::validate_parameters( self::update_user_parameters(), [ - 'lang' => $lang, 'theme' => $theme, 'colorblindness' => $colorblindness, 'displaytaskcount' => $displaytaskcount, @@ -83,9 +81,6 @@ public static function update_user($lang, $theme, $colorblindness, $displaytaskc throw new moodle_exception('User does not exist'); } $user = user_helper::get_user($USER->id); - if ($lang !== null) { - $user->set_lang($lang); - } if ($colorblindness !== null) { $user->set_colorblindness($colorblindness); } From 182438daa90b2a5507e7e5f69f1870807bba605f Mon Sep 17 00:00:00 2001 From: Riedler Date: Mon, 20 Jan 2025 11:10:47 +0100 Subject: [PATCH 2/2] fix: docstring --- lbplanner/services/user/update_user.php | 1 - 1 file changed, 1 deletion(-) diff --git a/lbplanner/services/user/update_user.php b/lbplanner/services/user/update_user.php index f0f785e8..4170f266 100644 --- a/lbplanner/services/user/update_user.php +++ b/lbplanner/services/user/update_user.php @@ -55,7 +55,6 @@ public static function update_user_parameters(): external_function_parameters { /** * Updates the given user in the lbplanner DB - * @param string $lang language the user choose * @param string $theme The theme the user has selected * @param string $colorblindness The colorblindness the user has selected * @param int $displaytaskcount The displaytaskcount the user has selected