diff --git a/lbplanner/classes/helpers/modules_helper.php b/lbplanner/classes/helpers/modules_helper.php index fa03f56e..d5b4768f 100644 --- a/lbplanner/classes/helpers/modules_helper.php +++ b/lbplanner/classes/helpers/modules_helper.php @@ -139,8 +139,9 @@ public static function determine_type(int $cmid): int { public static function get_module_status(module $module, int $userid, ?int $planid = null): int { global $DB; - if ($planid === null) { - $planid = plan_helper::get_plan_id($userid); + $grade = $module->get_grade($userid); + if ($grade !== null && $grade !== MODULE_GRADE::RIP) { + return MODULE_STATUS::DONE; } // Getting some necessary data. @@ -159,12 +160,11 @@ public static function get_module_status(module $module, int $userid, ?int $plan } } - $grade = $module->get_grade($userid); + // Check if the module is late. - if ($grade !== null && $grade !== MODULE_GRADE::RIP) { - return MODULE_STATUS::DONE; + if ($planid === null) { + $planid = plan_helper::get_plan_id($userid); } - // Check if the module is late. $deadline = $module->get_deadline($planid);