From 5699a86406a68daf7dc33d6aa74cd0da94400024 Mon Sep 17 00:00:00 2001
From: Riedler <git@riedler.wien>
Date: Wed, 24 Sep 2025 11:40:52 +0200
Subject: [PATCH 1/2] fix: remove notif types yet unsupported by our structure

---
 lbplanner/services/slots/book_reservation.php | 1 -
 lbplanner/services/slots/delete_slot.php      | 7 -------
 2 files changed, 8 deletions(-)

diff --git a/lbplanner/services/slots/book_reservation.php b/lbplanner/services/slots/book_reservation.php
index ab58ac43..2795f499 100644
--- a/lbplanner/services/slots/book_reservation.php
+++ b/lbplanner/services/slots/book_reservation.php
@@ -165,7 +165,6 @@ public static function book_reservation(int $slotid, string $date, int $userid):
                     slot_helper::TABLE_RESERVATIONS,
                     ['id' => $overlapres->id]
                 );
-                notifications_helper::notify_user($userid, $overlapres->id, NOTIF_TRIGGER::UNBOOK_FORCED);
             }
         }
 
diff --git a/lbplanner/services/slots/delete_slot.php b/lbplanner/services/slots/delete_slot.php
index 6c0a4873..f9dbee45 100644
--- a/lbplanner/services/slots/delete_slot.php
+++ b/lbplanner/services/slots/delete_slot.php
@@ -19,8 +19,6 @@
 use core_external\{external_api, external_function_parameters, external_value};
 
 use local_lbplanner\helpers\slot_helper;
-use local_lbplanner\helpers\notifications_helper;
-use local_lbplanner\enums\NOTIF_TRIGGER;
 
 /**
  * Deletes slot
@@ -63,11 +61,6 @@ public static function delete_slot(int $id): void {
         // Check if user is supervisor for this slot, throw error if not.
         slot_helper::assert_slot_supervisor($USER->id, $id);
 
-        // Notify affected users.
-        $reservations = slot_helper::get_reservations_for_slot($id);
-        foreach ($reservations as $res) {
-            notifications_helper::notify_user($res->userid, $res->id, NOTIF_TRIGGER::UNBOOK_FORCED);
-        }
         // Delete all reservations for this slot.
         $DB->delete_records(
             slot_helper::TABLE_RESERVATIONS,

From 30869bf193fc056894c623798c52396d79261ff3 Mon Sep 17 00:00:00 2001
From: Riedler <git@riedler.wien>
Date: Wed, 24 Sep 2025 11:50:36 +0200
Subject: [PATCH 2/2] fix: remove one more unsupported notif

---
 lbplanner/services/slots/unbook_reservation.php | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lbplanner/services/slots/unbook_reservation.php b/lbplanner/services/slots/unbook_reservation.php
index f092af4a..2a580829 100644
--- a/lbplanner/services/slots/unbook_reservation.php
+++ b/lbplanner/services/slots/unbook_reservation.php
@@ -94,8 +94,6 @@ public static function unbook_reservation(int $reservationid, bool $nice): void
                 }
                 notifications_helper::notify_user($reservation->userid, $reservation->id, NOTIF_TRIGGER::UNBOOK_REQUESTED);
                 return;
-            } else {
-                notifications_helper::notify_user($reservation->userid, $reservation->id, NOTIF_TRIGGER::UNBOOK_FORCED);
             }
         } else {
             throw new \moodle_exception('insufficient permission to unbook this reservation');