NeoForge 1.21.1 - Deprecated Features

[DroidCrafterMC]

I have been following the ModdingByKaupenjoe Neoforge 1.21.1 tutorial and have encountered an issue with the EventBusSubscriber in the Hammer tutorial. An image of the error can be found below.

My code: @EventBusSubscriber(modid = DroidsImplements.MOD_ID, bus = EventBusSubscriber.Bus.GAME)

Tutorial's code: https://github.com/Tutorials-By-Kaupenjoe/NeoForge-Tutorial-1.21.X/blob/16-hammerTool/src/main/java/net/kaupenjoe/tutorialmod/event/ModEvents.java

Help would be much appreciated.

[Spinoscythe]

Remove the bus = EventBusSubscriber.Bus.GAME part. Neo now automatically detects what bus an event is when you're subscribing to it.

[TelepathicGrunt]

Deprecated means it is discouraged from being used and like spino said, would be best to remove. However, that’s just a warning. Not an error that would prevent the mod from running

[ChiefArug]

You can just remove that bus parameter from the annotation as it is now figured out automatically based on the event's type.

Note this does mean you should require at least NeoForge 21.6.6 or higher in your neoforge.mods.toml.

[DroidCrafterMC]

Thank you all for your help.

[DroidCrafterMC]

I applied the changes but it does not work as intended. For the past few days I have been going through my code but I can't see what's wrong. It doesn't recognise any errors. Please excuse the poor formatting of the code, I'm fairly new to using it on GitHub and its acting a little odd.

ModEvents:

`import net.droidcrafter23.droidsimplements.item.custom.HeavyShovelItem;
import net.minecraft.core.BlockPos;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.ItemStack;
import net.neoforged.neoforge.event.level.BlockEvent;

import java.util.HashSet;
import java.util.Set;

public class ModEventsHeavyShovel {

private static final Set<BlockPos> HARVESTED_BLOCKS = new HashSet<>();

// Done with the help of https://github.com/CoFH/CoFHCore/blob/1.19.x/src/main/java/cofh/core/event/AreaEffectEvents.java
// Don't be a jerk License

public static void onHeavyShovelUsage(BlockEvent.BreakEvent event) {
    Player player = event.getPlayer();
    ItemStack mainHandItem = player.getMainHandItem();

    if(mainHandItem.getItem() instanceof HeavyShovelItem heavyShovelItem && player instanceof ServerPlayer serverPlayer) {
        BlockPos initialBlockPos = event.getPos();
        if(HARVESTED_BLOCKS.contains(initialBlockPos)) {
            return;
        }

        for(BlockPos pos : HeavyShovelItem.getBlocksToBeDestroyed(1, initialBlockPos, serverPlayer)) {
            if(pos == initialBlockPos || !heavyShovelItem.isCorrectToolForDrops(mainHandItem, event.getLevel().getBlockState(pos))) {
                continue;
            }

            HARVESTED_BLOCKS.add(pos);
            serverPlayer.gameMode.destroyBlock(pos);
            HARVESTED_BLOCKS.remove(pos);
        }
    }
}} `

Custom Item:

`package net.droidcrafter23.droidsimplements.item.custom;
import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.tags.BlockTags;
import net.minecraft.world.item.DiggerItem;
import net.minecraft.world.item.Tier;
import net.minecraft.world.level.ClipContext;
import net.minecraft.world.phys.BlockHitResult;
import net.minecraft.world.phys.HitResult;

import java.util.ArrayList;
import java.util.List;

public class HeavyShovelItem extends DiggerItem {
public HeavyShovelItem(Tier tier, Properties properties) {
super(tier, BlockTags.MINEABLE_WITH_PICKAXE, properties);
}

public static List<BlockPos> getBlocksToBeDestroyed(int range, BlockPos initalBlockPos, ServerPlayer player) {
    List<BlockPos> positions = new ArrayList<>();

    BlockHitResult traceResult = player.level().clip(new ClipContext(player.getEyePosition(1f),
            (player.getEyePosition(1f).add(player.getViewVector(1f).scale(6f))),
            ClipContext.Block.COLLIDER, ClipContext.Fluid.NONE, player));
    if(traceResult.getType() == HitResult.Type.MISS) {
        return positions;
    }

    if(traceResult.getDirection() == Direction.DOWN || traceResult.getDirection() == Direction.UP) {
        for(int x = -range; x <= range; x++) {
            for(int y = -range; y <= range; y++) {
                positions.add(new BlockPos(initalBlockPos.getX() + x, initalBlockPos.getY(), initalBlockPos.getZ() + y));
            }
        }
    }

    if(traceResult.getDirection() == Direction.NORTH || traceResult.getDirection() == Direction.SOUTH) {
        for(int x = -range; x <= range; x++) {
            for(int y = -range; y <= range; y++) {
                positions.add(new BlockPos(initalBlockPos.getX() + x, initalBlockPos.getY() + y, initalBlockPos.getZ()));
            }
        }
    }

    if(traceResult.getDirection() == Direction.EAST || traceResult.getDirection() == Direction.WEST) {
        for(int x = -range; x <= range; x++) {
            for(int y = -range; y <= range; y++) {
                positions.add(new BlockPos(initalBlockPos.getX(), initalBlockPos.getY() + y, initalBlockPos.getZ() + x));
            }
        }
    }

    return positions;
}}`

Tutorial ModEvents:

https://github.com/Tutorials-By-Kaupenjoe/NeoForge-Tutorial-1.21.X/blob/16-hammerTool/src/main/java/net/kaupenjoe/tutorialmod/event/ModEvents.java

Tutorial Custom Item:

https://github.com/Tutorials-By-Kaupenjoe/NeoForge-Tutorial-1.21.X/blob/16-hammerTool/src/main/java/net/kaupenjoe/tutorialmod/item/custom/HammerItem.java

[ChiefArug]

You removed a bit too much. You still need the @EventBusSubscriber and @SubscribeEvent annotations otherwise NeoForge doesn't see the methods as event handlers. (There are other ways of making NeoForge see those as event handlers, but the annotations are the simplest for the moment.)

The only bit you needed to remove to get rid of the deprecation warning was , bus = EventBusSubscriber.Bus.GAME.

[DroidCrafterMC]

Ah, okay. An easy mistake. Thank you for pointing that out.