Inconsistent Package Contents After Cloning into an Existing Package

[lapentad]

Inconsistent Package Contents After Cloning into an Existing Package

---

Summary

Cloning a package into the directory structure of an existing package revision results in an inconsistency between the contents of the Porch PackageRevisionResources and the underlying Git repository tags. Specifically, the Git tag associated with the last approved package revision includes files from both the original and the newly cloned package, making the package contents unreliable and dependent on the approval order.

---

Steps to Reproduce

1. Assume a repository named porch-test contains an existing package named root.

2. Clone an arbitrary package (porch-bp.subpackage.1) into a path that places it inside the existing root package's directory, for example, creating a new sub-directory named subpackage-clone:

   porchctl rpkg clone porch-bp.subpackage.1 --repository=porch-test --workspace=1 root/subpackage-clone

3. Observe the Porch PackageRevisionResources and the Git repository state and tags after approval.